refactor(openworkflow, cli): narrow isWorkflow to a type predicate#468
Merged
jamescmartinez merged 1 commit intomainfrom Apr 16, 2026
Merged
refactor(openworkflow, cli): narrow isWorkflow to a type predicate#468jamescmartinez merged 1 commit intomainfrom
jamescmartinez merged 1 commit intomainfrom
Conversation
typing `isWorkflow` as `value is Workflow<unknown, unknown, unknown>` lets callers drop the redundant `as Workflow<...>` cast in the CLI's workflow discovery loop. no behavior change.
commit: |
There was a problem hiding this comment.
Pull request overview
This PR refactors the isWorkflow helper in OpenWorkflow’s core to be a proper TypeScript type guard, allowing downstream code (notably the CLI workflow discovery/import logic) to rely on narrowing instead of explicit casts.
Changes:
- Updated
isWorkflowto return a TypeScript type predicate (value is Workflow<unknown, unknown, unknown>). - Simplified CLI workflow import logic by removing an unnecessary cast and using the narrowed value directly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/openworkflow/core/workflow-definition.ts | Changes isWorkflow signature to a type predicate for correct narrowing. |
| packages/cli/commands.ts | Removes redundant cast when collecting workflows after isWorkflow check. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.