379 update networkx #384
Closed
379 update networkx #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were untested and non-functional.
clbarnes
force-pushed
the
379-remove-networkx
branch
from
333b9ac to
a11f5d8
Compare
Contributor
Author
|
I suspect I misunderstand how the tests, and indeed POW, work. Should the test class have populated the Network? Does the Network need to be recontextualised, either in the test or in as_networkx? |
Contributor
|
Thanks, @clbarnes . NetworkX translation should preferably go in a DataTranslator. The networkx reference in the test and in the dependencies was cruft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Network.as_networkxnow does somethingNeuronhad some networkx methods which were untested, unused and didn't work, so I removed them