Skip to content

Created test to recreate issue #741#784

Closed
vringar wants to merge 1 commit intomasterfrom
disable_open_during_load
Closed

Created test to recreate issue #741#784
vringar wants to merge 1 commit intomasterfrom
disable_open_during_load

Conversation

@vringar
Copy link
Contributor

@vringar vringar commented Nov 10, 2020

This test currently fails.

@vringar vringar force-pushed the disable_open_during_load branch from a4ff0b6 to c55671d Compare September 21, 2022 18:57
@vringar vringar force-pushed the disable_open_during_load branch from c55671d to 9a01588 Compare September 5, 2023 13:39
@codecov
Copy link

codecov bot commented Sep 5, 2023 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.58%. Comparing base (40e044f) to head (a13fe31).
⚠️ Report is 6 commits behind head on master.

❌ Your project status has failed because the head coverage (20.58%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (40e044f) and HEAD (a13fe31). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (40e044f) HEAD (a13fe31)
2 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master     #784       +/-   ##
===========================================
- Coverage   56.62%   20.58%   -36.04%     
===========================================
  Files          40       35        -5     
  Lines        3910     3488      -422     
===========================================
- Hits         2214      718     -1496     
- Misses       1696     2770     +1074

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vringar vringar force-pushed the disable_open_during_load branch from 9a01588 to bca485c Compare September 25, 2023 09:33
@vringar vringar force-pushed the disable_open_during_load branch from bca485c to 6e7a0e6 Compare October 22, 2023 12:02
@vringar vringar force-pushed the disable_open_during_load branch from 6e7a0e6 to 5167109 Compare February 7, 2024 10:35
@vringar vringar force-pushed the disable_open_during_load branch from 5167109 to eb0ccf8 Compare August 2, 2024 14:58
@vringar vringar force-pushed the disable_open_during_load branch from eb0ccf8 to df6347e Compare February 26, 2026 23:03
vringar added a commit that referenced this pull request Feb 26, 2026
@vringar
fix: use WebDriver new_window instead of JS window.open in tab_restar…
03c7dfd 
…t_browser

Replace the Selenium 3 workaround (JS window.open) with Selenium 4
switch_to.new_window(), which uses the WebDriver protocol and is not
blocked by popup-blocking preferences like dom.disable_open_during_load.

Closes #741, closes #784
@vringar vringar mentioned this pull request Feb 26, 2026
Merged
4 tasks
vringar added a commit that referenced this pull request Feb 26, 2026
@vringar
fix: use WebDriver new_window instead of JS window.open in tab_restar…
b390ab7 
…t_browser

Replace the Selenium 3 workaround (JS window.open) with Selenium 4
switch_to.new_window(), which uses the WebDriver protocol and is not
blocked by popup-blocking preferences like dom.disable_open_during_load.

Closes #741, closes #784
Copilot AI review requested due to automatic review settings February 26, 2026 23:47
@vringar vringar force-pushed the disable_open_during_load branch from df6347e to a13fe31 Compare February 26, 2026 23:47
Copilot AI reviewed Feb 26, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a test case to reproduce issue #741, which appears to be related to finalization behavior when no popups are present. The test configures a browser with popup blocking enabled and verifies that visiting a simple page does not result in command failures.

Changes:

  • Added a new test file test_finalize.py with a test case that reproduces issue #741

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/test_finalize.py
from .openwpmtest import OpenWPMTest


class TestExtension(OpenWPMTest):
Copy link

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class name 'TestExtension' does not match the purpose of testing finalization behavior. Consider renaming to 'TestFinalize' to accurately reflect the test's purpose and improve code clarity.

Suggested change
class TestExtension(OpenWPMTest):
class TestFinalize(OpenWPMTest):

Copilot uses AI. Check for mistakes.
vringar added a commit that referenced this pull request Feb 27, 2026
@vringar
fix: use WebDriver new_window instead of JS window.open in tab_restar…
8d32b8f 
…t_browser

Replace the Selenium 3 workaround (JS window.open) with Selenium 4
switch_to.new_window(), which uses the WebDriver protocol and is not
blocked by popup-blocking preferences like dom.disable_open_during_load.

Closes #741, closes #784
vringar added a commit that referenced this pull request Feb 28, 2026
@vringar
fix: use WebDriver new_window instead of JS window.open in tab_restar…
48b1400 
…t_browser

Replace the Selenium 3 workaround (JS window.open) with Selenium 4
switch_to.new_window(), which uses the WebDriver protocol and is not
blocked by popup-blocking preferences like dom.disable_open_during_load.

Closes #741, closes #784
github-merge-queue bot pushed a commit that referenced this pull request Feb 28, 2026
@vringar
fix: use WebDriver new_window instead of JS window.open in tab_restar…
1f96052 
…t_browser

Replace the Selenium 3 workaround (JS window.open) with Selenium 4
switch_to.new_window(), which uses the WebDriver protocol and is not
blocked by popup-blocking preferences like dom.disable_open_during_load.

Closes #741, closes #784
github-merge-queue bot pushed a commit that referenced this pull request Feb 28, 2026
@vringar
fix: use WebDriver new_window instead of JS window.open in tab_restar…
782c66e 
…t_browser

Replace the Selenium 3 workaround (JS window.open) with Selenium 4
switch_to.new_window(), which uses the WebDriver protocol and is not
blocked by popup-blocking preferences like dom.disable_open_during_load.

Closes #741, closes #784
github-merge-queue bot pushed a commit that referenced this pull request Mar 1, 2026
@vringar
fix: use WebDriver new_window instead of JS window.open in tab_restar…
5e4a35b 
…t_browser

Replace the Selenium 3 workaround (JS window.open) with Selenium 4
switch_to.new_window(), which uses the WebDriver protocol and is not
blocked by popup-blocking preferences like dom.disable_open_during_load.

Closes #741, closes #784
@vringar vringar closed this in #1146 Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

high-priority

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vringar