kernel: rtl8261n: Always configure as USXGMII#23076
Merged
openwrt-bot merged 3 commits intoopenwrt:mainfrom Apr 25, 2026
Merged
kernel: rtl8261n: Always configure as USXGMII#23076openwrt-bot merged 3 commits intoopenwrt:mainfrom
openwrt-bot merged 3 commits intoopenwrt:mainfrom
Conversation
Contributor
Author
|
@jonasjelonek Can you please double check this PR? Not that I've messed something up. You have much more knowledge in this field. |
jonasjelonek
suggested changes
Apr 24, 2026
Contributor
jonasjelonek
left a comment
jonasjelonek
left a comment
There was a problem hiding this comment.
Let's see how many additional IRQ comments it'll take until the other PR is in so the old driver can be dropped ...
Otherwise good, also just tested this on my Realtek switch with RTL8261 and it works.
github-actions
Bot
added
the
kernel
ecsv
force-pushed
the
rtl8261n-std-usxgmii
branch
from
f9cdf08 to
27bddb2
Compare
jonasjelonek
approved these changes
Apr 24, 2026
Contributor
jonasjelonek
left a comment
jonasjelonek
left a comment
There was a problem hiding this comment.
Thank you. Tested on (yet unsupported) SKS7300-4X4T with RTL8261N
Contributor
|
Please reword the first commit message. Some clumsy sentences there. |
Contributor
|
And another nit. In the last commit ther is a ":" missing
|
ecsv
force-pushed
the
rtl8261n-std-usxgmii
branch
5 times, most recently
from
11e3b02 to
282c30d
Compare
Contributor
Author
Reworded it - will stop for now because I think I've ended up in a loop of rewording-only pushes. |
plappermaul
approved these changes
Apr 24, 2026
Contributor
|
@robimarko good to go. Thanks in advance. |
The PHY register patch in question is gated by `CONFIG_MACH_REALTEK_RTL`, has no documented/expected behavior, and is in practice unreachable: `phy_patch()` is only called from `rtkphy_config_init()`, which is exits (too) early for `CONFIG_MACH_REALTEK_RTL` builds. Remove it as a cleanup step before enabling standard USXGMII configuration for these PHYs. Fixes: b77fa45 ("kernel: fix rtl8261n driver for realtek") Co-authored-by: Jonas Jelonek <jelonek.jonas@gmail.com> Signed-off-by: Sven Eckelmann <sven@narfation.org> Link: openwrt#23076 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
In the past, all the configuration of SerDes and PHYs on the realtek switches were done using u-boot (`rtk init`). But since RTL930x switched to SerDes configuration under Linux, the SoC side is no longer using the Realtek-proprietary variant of USXGMII. The communication to the RTL8261N PHYs on those switches broke because of this incompatibility. Enabling the full initialization on `CONFIG_MACH_REALTEK_RTL` converts also the PHY side to the standard USXGMII and therefore ensures that both sides speak the same dialect. Co-authored-by: Jonas Jelonek <jelonek.jonas@gmail.com> Signed-off-by: Sven Eckelmann <sven@narfation.org> Link: openwrt#23076 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
After the RTL8261N asserts a reset, the MDIO bus becomes temporarily unavailable during the chip's reinitialization sequence. Any subsequent read or write issued before the PHY has stabilized will fail. Add a 30ms delay after triggering the reset to ensure the chip is reachable via MDIO before resuming communication. Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com> Signed-off-by: Sven Eckelmann <sven@narfation.org> Link: openwrt#23076 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
hauke
force-pushed
the
rtl8261n-std-usxgmii
branch
from
282c30d to
51992c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the past, all the configuration of SerDes and PHYs on the realtek switches were done using u-boot (
rtk init). But since RTL930x switched to SerDes configuration under Linux, the SoC side is no longer using the Realtek-proprietary variant of USXGMII. The communication to the RTL8261N PHYs on those switches broke because of this incompatibility.Enabling the full initialization on
CONFIG_MACH_REALTEK_RTLconverts also the PHY side to the standard USXGMII and therefore ensures that both sides speak the same dialect.In this process, also an undocumented
CONFIG_MACH_REALTEK_RTLonly patch needs to be removed. It was never actually reached before. Simply, becausertkphy_config_init()returned onCONFIG_MACH_REALTEK_RTLswitches before the PHY patching was reached. But it also seems to be wrong to apply it now. The SerDes<->PHY communication should use the standard USXGMII and not some proprietary Realtek variant.This was mostly extracted from a discussion with @jonasjelonek (#22563 (comment))