mvebu: enable coherent crypto on armada 37x0#23646
Conversation
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit. The patch adds the upstream dma-coherent property to the EIP97 node for both 6.12 and 6.18; hunk context and line numbers (440 for 6.12, 438 for 6.18) match the respective kernel armada-37xx.dtsi, and the commit message matches the change. One filename nit inline.
Generated by Claude Code
833e409 to
8144d28
Compare
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed the new revision; no new issues found. The only change since the last review is renaming both patches from the 350- prefix to 340-, which resolves the earlier prefix-collision nit. The 340- prefix is unused in both patches-6.12/ and patches-6.18/ (existing DTS patches run 320–326), and the patch contents are unchanged.
Generated by Claude Code
Armada 37xx has coherent bus, similar to Armada 7k/8k. Cache synchronization consumes a lot of CPU cycles. Enabling coherent DMA increases IOPS performance up to 4 times. Some numbers: Data length Algo MB 16 64 128 256 1024 1424 4096 DES-ECB 1 +21 % +5 % +5 % +7 % +7 % +3 % +20 % AES-ECB-128 1 +21 % +6 % +6 % +6 % +9 % +8 % +22 % AES-CBC-128 1 +21 % +5 % +5 % +5 % +6 % +7 % +23 % AES-CBC-256 1 +23 % +7 % +8 % +6 % +11 % +13 % +20 % Data length Algo MB 16 64 256 512 1024 1420 4096 8192 AES-GCM-128 1 +44 % +42 % +31 % +32 % +27 % +30 % +32 % +30 % AES-GCM-128 8 +319 % +326 % +163 % +148 % +75 % +72 % +74 % +41 % AES-GCM-128 4096 +123 % +128 % +90 % +83 % +116 % +59 % +38 % +28 % Data length Algo MB 16 64 256 1024 2048 4096 8192 MD5 1 +21 % +15 % +29 % +25 % +50 % +16 % +20 % SHA1 1 +24 % +22 % +27 % +22 % +18 % +20 % +20 % SHA256 1 +30 % +24 % +25 % +26 % +21 % +41 % +19 % SHA512 1 +4 % +3 % +8 % +10 % +24 % +10 % +11 % Tested on Armada 3720. Platform passes testmgr selftests. Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl> Link: openwrt#23646 Signed-off-by: Robert Marko <robimarko@gmail.com>
8144d28 to
1480790
Compare
|
Thanks! Rebased on top of main and merged! |
Armada 37xx has coherent bus, similar to Armada 7k/8k. Cache synchronization consumes a lot of CPU cycles. Enabling coherent DMA increases IOPS performance up to 4 times. Some numbers:
Tested on Armada 3720. Platform passes testmgr selftests.
Signed-off-by: Aleksander Jan Bajkowski olek2@wp.pl