Skip to content

perl: fix build failure in GCC10#12391

Merged
pprindeville merged 1 commit intoopenwrt:masterfrom
dwmw2:perlfix
Jun 4, 2020
Merged

perl: fix build failure in GCC10#12391
pprindeville merged 1 commit intoopenwrt:masterfrom
dwmw2:perlfix

Conversation

@dwmw2
Copy link
Copy Markdown
Contributor

@dwmw2 dwmw2 commented Jun 3, 2020

The perl Configure file was matching GCC 10 against "1*" and treating it
as GCC 1, causing ABI breakage and segfaults.

Cherry-pick the upstream patch which fixes it to check against (e.g)
"1.*" instead, which will make it work for hundreds more GCC versions
to come.

Perl/perl5@6bd6308fcea3541

Signed-off-by: Ken Wong xinxijishuwyq@gmail.com

Maintainer: @pprindeville @Naoir
Compile tested: Asus RT-AC85P, OpenWRT master
Run tested: x

This supersedes #12178 in which we're being cruel to a potential contributor by asking them to "fix" their commit message without telling them how. If they knew what we were asking for, they might have done it in the first place.

@xinxijishuwyq here's what I think you were being asked for:
• Make it clearer that the patch is cherry-picked from upstream, and provide the reference
• Use the precise patch that was merged upstream (there are a couple of minor differences)
• Include an explanation of the problem in the OpenWRT commit message.

Thanks for your contribution to OpenWRT!

The perl Configure file was matching GCC 10 against "1*" and treating it
as GCC 1, causing ABI breakage and segfaults.

Cherry-pick the upstream patch which fixes it to check against (e.g)
"1.*" instead, which will make it work for hundreds more GCC versions
to come.

Perl/perl5@6bd6308fcea3541
 "Adapt Configure to GCC version 10"

Also includes the previous commit just adding GCC 8 and 9 to one case:
Perl/perl5@ae195500577d707
 "Add gcc-8 and gcc-9 for FORTIFY_SOURCE"

Signed-off-by: Ken Wong <xinxijishuwyq@gmail.com>
@pprindeville
Copy link
Copy Markdown
Member

pprindeville commented Jun 4, 2020

This supersedes #12178 in which we're being cruel to a potential contributor by asking them to "fix" their commit message without telling them how. If they knew what we were asking for, they might have done it in the first place.

Wow. You mean telling them like I did here?

Please fix the initial comment.

@xinxijishuwyq Waiting on this. You can click on "..." on the top right side of the comment box and select "edit" to make changes.

That was 4 days ago and from what I can tell, you've done nothing with that information.

Further, packages has a template that the initial comment gets pre-populated with. It's there for a reason. Use it appropriately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants