perl: fix build failure in GCC10#12391
Merged
pprindeville merged 1 commit intoopenwrt:masterfrom Jun 4, 2020
Merged
Conversation
The perl Configure file was matching GCC 10 against "1*" and treating it as GCC 1, causing ABI breakage and segfaults. Cherry-pick the upstream patch which fixes it to check against (e.g) "1.*" instead, which will make it work for hundreds more GCC versions to come. Perl/perl5@6bd6308fcea3541 "Adapt Configure to GCC version 10" Also includes the previous commit just adding GCC 8 and 9 to one case: Perl/perl5@ae195500577d707 "Add gcc-8 and gcc-9 for FORTIFY_SOURCE" Signed-off-by: Ken Wong <xinxijishuwyq@gmail.com>
Member
Wow. You mean telling them like I did here?
That was 4 days ago and from what I can tell, you've done nothing with that information. Further, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The perl Configure file was matching GCC 10 against "1*" and treating it
as GCC 1, causing ABI breakage and segfaults.
Cherry-pick the upstream patch which fixes it to check against (e.g)
"1.*" instead, which will make it work for hundreds more GCC versions
to come.
Perl/perl5@6bd6308fcea3541
Signed-off-by: Ken Wong xinxijishuwyq@gmail.com
Maintainer: @pprindeville @Naoir
Compile tested: Asus RT-AC85P, OpenWRT master
Run tested: x
This supersedes #12178 in which we're being cruel to a potential contributor by asking them to "fix" their commit message without telling them how. If they knew what we were asking for, they might have done it in the first place.
@xinxijishuwyq here's what I think you were being asked for:
• Make it clearer that the patch is cherry-picked from upstream, and provide the reference
• Use the precise patch that was merged upstream (there are a couple of minor differences)
• Include an explanation of the problem in the OpenWRT commit message.
Thanks for your contribution to OpenWRT!