Skip to content

ddns-scripts: Remove minimum 5 minute wait#20565

Merged
feckert merged 1 commit intoopenwrt:masterfrom
brianjmurrell:patch-5
Dec 17, 2025
Merged

ddns-scripts: Remove minimum 5 minute wait#20565
feckert merged 1 commit intoopenwrt:masterfrom
brianjmurrell:patch-5

Conversation

@brianjmurrell
Copy link
Contributor

Maintainer: unclear by checking history of the package Makefile

Description:
To check if the update was successful.

Not all DDNS implementations have such huge latencies updating their services.

nsupdate for example, updates immediately and the update is immediately checkable.

Fixes: #20564

@brianjmurrell
Copy link
Contributor Author

I don't think the CI failures are related to the nature of this PR. They look systememic.

@feckert
Copy link
Member

feckert commented Apr 18, 2023

My problem here is that if I merge this, then it could be that the DDNS no longer works for others, because they already had the wrong value before which is no longer fixed. I would therefore suggest that we use some kind of force that overrides the check.

@brianjmurrell
Copy link
Contributor Author

My problem here is that if I merge this, then it could be that the DDNS no longer works for others, because they already had the wrong value before which is no longer fixed.

IMO, proper behaviour and bug fixing should never be avoided due to configurations relying on improper behaviour. Those broken configurations need to be fixed to work with proper values. IOW, any configuration that actually needs 5 minutes for the check needs to specify 5 minutes. Not 2 minutes, not 4 minutes, not 1 minute or even 30 seconds, etc.

I would therefore suggest that we use some kind of force that overrides the check.

So yet another option, perhaps, check_interval_minimum that defaults to the previously broken value of 300 seconds, but can be set lower, explicitly? Or a new, confusing, second check_interval_real perhaps that overrides check_interval?

@GeorgeSapkin
Copy link
Member

@brianjmurrell still relevant? Commits needs to be squashed, PKG_RELEASE needs a bump and commit subject needs to start with a lowercase after the prefix.

@brianjmurrell
Copy link
Contributor Author

@GeorgeSapkin Done. Thanks.

To check if the update was successful.

Not all DDNS implementations have such huge latencies updating their services.

nsupdate for example, updates immediately and the update is immediately checkable.

Add new check_interval_min value to be able to set a check interval lower than the
previously hard-coded 5 minutes.

Fixes: openwrt#20564

Signed-off-by: Brian J. Murrell <brian@interlinx.bc.ca>
@feckert
Copy link
Member

feckert commented Dec 17, 2025

Thank you for your work.

@feckert feckert merged commit 63308ab into openwrt:master Dec 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ddns-scripts: check_interval should be allowed smaller than 5 mins

3 participants