ddns-scripts: Remove minimum 5 minute wait#20565
Conversation
|
I don't think the CI failures are related to the nature of this PR. They look systememic. |
|
My problem here is that if I merge this, then it could be that the DDNS no longer works for others, because they already had the wrong value before which is no longer fixed. I would therefore suggest that we use some kind of force that overrides the check. |
IMO, proper behaviour and bug fixing should never be avoided due to configurations relying on improper behaviour. Those broken configurations need to be fixed to work with proper values. IOW, any configuration that actually needs 5 minutes for the check needs to specify 5 minutes. Not 2 minutes, not 4 minutes, not 1 minute or even 30 seconds, etc.
So yet another option, perhaps, |
|
@brianjmurrell still relevant? Commits needs to be squashed, |
7d3f5b8 to
8729bc9
Compare
|
@GeorgeSapkin Done. Thanks. |
To check if the update was successful. Not all DDNS implementations have such huge latencies updating their services. nsupdate for example, updates immediately and the update is immediately checkable. Add new check_interval_min value to be able to set a check interval lower than the previously hard-coded 5 minutes. Fixes: openwrt#20564 Signed-off-by: Brian J. Murrell <brian@interlinx.bc.ca>
8729bc9 to
71e3f9d
Compare
|
Thank you for your work. |
Maintainer: unclear by checking history of the package Makefile
Description:
To check if the update was successful.
Not all DDNS implementations have such huge latencies updating their services.
nsupdate for example, updates immediately and the update is immediately checkable.
Fixes: #20564