Merged
Conversation
|
Please do no longer set PKG_RELEASE to AUTORELEASE as the
|
Closed
bam80
force-pushed
the
master
branch
3 times, most recently
from
8809284 to
e5bb78f
Compare
BKPepe
reviewed
Jan 4, 2024
bam80
force-pushed
the
master
branch
2 times, most recently
from
76f8af5 to
48f129c
Compare
Contributor
Author
|
Ping, please? |
Member
|
Why there isn't specified version in the commit subject? I mean why did you chose to have vague commit subject? "Version bump" will be everytime, thats not helpful for history. |
Fixes: "no SMS Messages if some of them contain From: field with special symbols": 4IceG/luci-app-sms-tool-js#9 Signed-off-by: Andrey Butirsky <butirsky@gmail.com>
Contributor
Author
|
@BKPepe done |
Contributor
Author
|
@BKPepe As you here, could I ask you to merge this one also: This was ready apart from the commit message which I fixed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer: me
Run tested: mipsel, OpenWrt 23.05.0-rc3, problem in the Description solved.
Description:
Fixes:
"no SMS Messages if some of them contain From: field with special symbols":
4IceG/luci-app-sms-tool-js#9