Cligen review comments#22823
Merged
1715173329 merged 1 commit intoopenwrt:masterfrom Dec 7, 2023
Merged
Conversation
Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
pprindeville
force-pushed
the
cligen-review-comments
branch
from
0b7ca37 to
d91f52e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some review comments came in after merge, so we'll address them here.
Maintainer: me, @olofhagsand
Compile tested: x86_64, generic, HEAD (ae500e6)
Run tested: same, installed on VM
Description: