hyperscan: symlinks redundant ABI shared objects#23512
Merged
neheb merged 1 commit intoopenwrt:masterfrom Feb 23, 2024
Merged
Conversation
Contributor
|
Looks good to me! |
Use $(CP) macro rather than $(INSTALL_DATA) to preserve symlinks on shared objects which saves approx 11.8 M of space. From hyperscan-runtime_5.4.2-1: % ls -lh /usr/lib/libhs* -rw-r--r-- 1 root root 4.7M Feb 16 14:29 /usr/lib/libhs.so -rw-r--r-- 1 root root 4.7M Feb 16 14:29 /usr/lib/libhs.so.5 -rw-r--r-- 1 root root 4.7M Feb 16 14:29 /usr/lib/libhs.so.5.4.2 -rw-r--r-- 1 root root 1.2M Feb 16 14:29 /usr/lib/libhs_runtime.so -rw-r--r-- 1 root root 1.2M Feb 16 14:29 /usr/lib/libhs_runtime.so.5 -rw-r--r-- 1 root root 1.2M Feb 16 14:29 /usr/lib/libhs_runtime.so.5.4.2 % grep Installed-Size /usr/lib/opkg/info/hyperscan-runtime.control Installed-Size: 18370560 From hyperscan-runetime_5.4.2-2 (created by this PR): % ls -lh /usr/lib/libhs* lrwxr-xr-x 1 root root 10 Feb 22 15:56 /usr/lib/libhs.so -> libhs.so.5 lrwxr-xr-x 1 root root 14 Feb 22 15:56 /usr/lib/libhs.so.5 -> libhs.so.5.4.2 -rwxr-xr-x 1 root root 4.6M Feb 22 15:27 /usr/lib/libhs.so.5.4.2 lrwxr-xr-x 1 root root 18 Feb 22 15:56 /usr/lib/libhs_runtime.so -> libhs_runtime.so.5 lrwxr-xr-x 1 root root 22 Feb 22 15:56 /usr/lib/libhs_runtime.so.5 -> libhs_runtime.so.5.4.2 -rwxr-xr-x 1 root root 1.2M Feb 22 15:27 /usr/lib/libhs_runtime.so.5.4.2 % grep Installed-Size /usr/lib/opkg/info/hyperscan-runtime.control Installed-Size: 5918720 Credit to @efahl for pointing this out. Build system: x86/64 Build-tested: x86/64/AMD Cezanne Run-tested: x86/64/AMD Cezanne Signed-off-by: John Audia <therealgraysky@proton.me>
graysky2
force-pushed
the
hyperscan-linked
branch
from
a95be3d to
2f81094
Compare
Contributor
Author
Thanks for the private email pointing this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
$(CP)macro rather than$(INSTALL_DATA)to preserve symlinks on shared objects which saves approx 11.8 M of space.From hyperscan-runtime_5.4.2-1:
From hyperscan-runetime_5.4.2-2 (created by this PR):
Credit to @efahl for pointing this out.
Build system: x86/64
Build-tested: x86/64/AMD Cezanne
Run-tested: x86/64/AMD Cezanne