rp-pppoe: Add back from oldpackages with build fixes and enhanced pac…#2403
Conversation
…kaging Add back from oldpackages with fixes for build errors and UCIfication (for future LuCI app). Signed-off By: Daniel Dickinson
Relay package was broken and not noticed due to lack of testing; fix the known breakage, but also mark BROKEN because untested. Signed-off-by: Daniel Dickinson <openwrt@daniel.thecshore.com>
|
Marked relay as broken (as untested) the same as already done with client and was intended for relay. |
|
I'd like to suggest that we use "thinner" uci layer for such services. UCI can be useful for fitting third-party programs into OpenWrt environment, e.g. procd service management, netifd interface event trigger, stdout/stderr logging etc. But in my opinion another full-fledged layer for translating every single options of those original services is overkill and serves not much good. Usability is also hurt because many times users will need to consult both the original services manual and uci config manual (and/or service script) to find the correspondence. In the case of pppoe-server, since it only accepts command line options and does not support parsing a config file, I would suggest we just add a single uci option |
|
My reasoning is that I intend to add a LuCI app - just args isn't the way to do that. |
|
Ultimately you are right that uci for the sake of uci doesn't make sense; but for integration with LuCI or other automated processing, a full layer is what is needed. |
|
The very existence of the rp-pppoe-client caused some confusion among users in the past - do we actually need it or is the existing ppp-mod-pppoe good enough for all PPPoE client needs? If so I'd suggest to keep server and relay but not the client. |
|
Reprioritizing my project queue and this didn't make the cut. Leaving branch intact in case someone wants to revive it. |
ghost
closed this
This is a feaure and bugfix release. New features: bsdtar: support --mtime and --clamp-mtime (openwrt#2601) lib: mbedtls 3.x compatibility (openwrt#2602) 7-zip reader: improve self-extracting archive detection (openwrt#2088) xar: xmllite support for the XAR reader and writer (openwrt#2388) zip writer: added XZ, LZMA, ZSTD and BZIP2 support (openwrt#2137, openwrt#2284, openwrt#2391) zip writer: added LZMA + RISCV BCJ filter (openwrt#2403) Notable security fixes: rar: do not skip past EOF while reading (openwrt#2584) rar: fix double free with over 4 billion nodes (openwrt#2598) rar: fix heap-buffer-overflow (openwrt#2599) warc: prevent signed integer overflow (openwrt#2568) tar: fix overflow in build_ustar_entry (openwrt#2588) Notable bugfixes: ibarchive: fix FILE_skip regression (openwrt#2642) compress: Prevent call stack overflow (openwrt#2649) iso9660: always check archive_string_ensure return value (openwrt#2651) tar: Support negative time values with pax (openwrt#2634) tar: Reset accumulated header state after reading macOS metadata blob (openwrt#2636) tar: Keep block alignment after pax error (openwrt#2637) tar: Handle extra bytes after sparse entries (openwrt#2643) windows: check archive_wstring_ensure return value (openwrt#2652) bsdtar: don't hardlink negative inode files together (openwrt#2587) gz: allow setting the original filename for gzip compressed files (openwrt#2544) lib: improve lseek handling (openwrt#2564) lib: support @-prefixed Unix epoch timestamps as date strings (openwrt#2606) rar: support large headers on 32 bit systems (openwrt#2596) tar reader: Improve LFS support on 32 bit systems (openwrt#2582) Full changelog: libarchive/libarchive@v3.7.9...v3.8.1 Build system: x86/64 Build-tested: x86/64 Run-tested: x86/64 Signed-off-by: John Audia <therealgraysky@proton.me>
This is a feaure and bugfix release. New features: bsdtar: support --mtime and --clamp-mtime (#2601) lib: mbedtls 3.x compatibility (#2602) 7-zip reader: improve self-extracting archive detection (#2088) xar: xmllite support for the XAR reader and writer (#2388) zip writer: added XZ, LZMA, ZSTD and BZIP2 support (#2137, #2284, #2391) zip writer: added LZMA + RISCV BCJ filter (#2403) Notable security fixes: rar: do not skip past EOF while reading (#2584) rar: fix double free with over 4 billion nodes (#2598) rar: fix heap-buffer-overflow (#2599) warc: prevent signed integer overflow (#2568) tar: fix overflow in build_ustar_entry (#2588) Notable bugfixes: ibarchive: fix FILE_skip regression (#2642) compress: Prevent call stack overflow (#2649) iso9660: always check archive_string_ensure return value (#2651) tar: Support negative time values with pax (#2634) tar: Reset accumulated header state after reading macOS metadata blob (#2636) tar: Keep block alignment after pax error (#2637) tar: Handle extra bytes after sparse entries (#2643) windows: check archive_wstring_ensure return value (#2652) bsdtar: don't hardlink negative inode files together (#2587) gz: allow setting the original filename for gzip compressed files (#2544) lib: improve lseek handling (#2564) lib: support @-prefixed Unix epoch timestamps as date strings (#2606) rar: support large headers on 32 bit systems (#2596) tar reader: Improve LFS support on 32 bit systems (#2582) Full changelog: libarchive/libarchive@v3.7.9...v3.8.1 Build system: x86/64 Build-tested: x86/64 Run-tested: x86/64 Signed-off-by: John Audia <therealgraysky@proton.me>
2 participants
…kaging
Add back from oldpackages with fixes for build errors and UCIfication
(for future LuCI app).
Signed-off By: Daniel Dickinson