Skip to content

treewide: fix EXTRA_DEPENDS#27908

Merged
GeorgeSapkin merged 3 commits intoopenwrt:masterfrom
GeorgeSapkin:treewide-fix-extra-depends
Nov 25, 2025
Merged

treewide: fix EXTRA_DEPENDS#27908
GeorgeSapkin merged 3 commits intoopenwrt:masterfrom
GeorgeSapkin:treewide-fix-extra-depends

Conversation

@GeorgeSapkin
Copy link
Copy Markdown
Member

@GeorgeSapkin GeorgeSapkin commented Nov 20, 2025

Maintainer: @Noltari, @PolynomialDivision

Description:

EXTRA_DEPENDS should be used for version constraints. Change to DEPENDS.

Remaining package addressed here:

Related to:


🧪 Run Testing Details

  • OpenWrt Version: SNAPSHOT
  • OpenWrt Target/Subtarget: x86/64
  • OpenWrt Device: QEMU

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

@map-b
Copy link
Copy Markdown

map-b commented Nov 20, 2025

One more?:

EXTRA_DEPENDS:=$(if $(CONFIG_PACKAGE_TAR_XZ),xz)

EXTRA_DEPENDS should be used for version constraints. Change to DEPENDS.

Fixes: e36e8a6 ("airos-dfs-reset: add airos-dfs-reset")
Signed-off-by: George Sapkin <george@sapk.in>
EXTRA_DEPENDS should be used for version constraints. Change to DEPENDS.

Fixes: e4a8d3f ("ubnt-manager: add ubnt-manager")
Signed-off-by: George Sapkin <george@sapk.in>
EXTRA_DEPENDS should be used for version constraints. Change to DEPENDS.

Fixes: 488be84 ("utils/tar: Make compression, acl, and xattr support configuration options")
Signed-off-by: George Sapkin <george@sapk.in>
@GeorgeSapkin GeorgeSapkin force-pushed the treewide-fix-extra-depends branch from cd8b721 to e2f2765 Compare November 20, 2025 16:57
@BKPepe
Copy link
Copy Markdown
Member

BKPepe commented Nov 21, 2025

If we are dropping EXTRA_DEPENDS and moving these dependencies into DEPENDS. Shouldn't we bump the PKG_RELEASE?

@GeorgeSapkin
Copy link
Copy Markdown
Member Author

GeorgeSapkin commented Nov 21, 2025

If we are dropping EXTRA_DEPENDS and moving these dependencies into DEPENDS. Shouldn't we bump the PKG_RELEASE?

This doesn't really change anything about the end result, so I don't think it makes sense to change the release. But I don't have strong feelings about this.

@GeorgeSapkin GeorgeSapkin merged commit 593267a into openwrt:master Nov 25, 2025
11 checks passed
@GeorgeSapkin GeorgeSapkin deleted the treewide-fix-extra-depends branch November 25, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants