prometheus-node-exporter-lua: add chip_name to temperature metric collection#28092
prometheus-node-exporter-lua: add chip_name to temperature metric collection#28092vgropp wants to merge 1 commit into
Conversation
|
The commit message needs to be prefixed with a package name and follow the 50/75 rule as per the submissions guidelines. And the package needs a |
|
sorry for not following guidelines, i hope its fine now |
|
ok, i have no clue at all about these build failures. I can see libcurl recursive dependency and other errors but i dont understand why the build is failing by a change in the .lua script. I hope ill find more time to debug the full build process the next days |
adds chip_name to temp metrics to remove duplicate sample with mt7996 Signed-off-by: Volker Gropp <volker@gropp.org>
|
as i am still not able to reproduce a full build and this keeps failing but the patched version is working on my devices i have to step back fixing this, sorry. I would love to step back in if anyone can give me a hint what to fix or at least where to find the build error. |
|
@vgropp sorry for the delay, can you run the official node exporter on the BPI-R4 and see what we get ? |
|
in 1.11.1 / 2026-04-07 i get: and in sysout: so its the same bug but a bit different behavior. I would really love to see the bpi-r4 support by the lua for all three bands |
removes duplicate sample with mt7996 and others with multiple radios
📦 Package Details
Maintainer: @champtar
Description:
Using the hwmon collector with a Banana Pi BPI-R4 there are duplicate samples for
node_hwmon_temp_celsius{sensor="temp1",chip="ieee80211_phy0"}. This results in prometheus warnings:level=WARN source=scrape.go:1923 msg="Error on ingesting samples with different value but same timestamp" component="scrape manager" scrape_pool=node-exporter target=http://<ip>:9100/metrics num_dropped=2Adding the chip_name to node_hwmon_temp_celsius fixes this.
Current metrics:
Banana Pi BPI-R4
GL.iNet GL-MT6000
Fixed metrics:
Banana Pi BPI-R4
GL.iNet GL-MT6000
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.