tar: fix circular dependency on xz #28142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tar depended both on xz and xz-utils which xz already depended on. Coupled with if PACKAGE_tar check it caused all packages that depended on tar to have a circular Kconfig dependency. Remove the check and dependency on xz-utils and leave xz one only. Move libzstd dependency into DEPENDS. Fixes: ad82c17 ("tar: fix EXTRA_DEPENDS") Fixes: openwrt#28141 Signed-off-by: George Sapkin <george@sapk.in>
sinancetinkaya
left a comment
sinancetinkaya
left a comment
There was a problem hiding this comment.
looks good, no errors
touch .config
[ -L .config ] && export KCONFIG_OVERWRITECONFIG=1; \
scripts/config/conf --defconfig=.config Config.in
#
# No change to .config
#
GeorgeSapkin
force-pushed
the
tar-fix-circular-dependency
branch
from
4b3f865 to
a444c74
Compare
Member
Author
|
Merging this so if more thins break, this can be caught before 25.12 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @Noltari, cc: @sinancetinkaya
Description:
Third time's the charm 🙈
tar depended both on xz and xz-utils which xz already depended on. Coupled with
if PACKAGE_tarcheck it caused all packages that depended on tar to have a circular Kconfig dependency. Remove the check and dependency on xz-utils and leave xz one only.Move libzstd dependency into DEPENDS.
Fixes: ad82c17 ("tar: fix EXTRA_DEPENDS")
Fixes: #28141
Related:
🧪 Run Testing Details
make defconfigdoesn't return any error related to tar with all the packages that depend on it selected. tar itself works as expected and installs xz with it. But I'm having issues building packages that depend on Perl locally (will do a clean build of the toolchain), so I can't fully test everything.@sinancetinkaya can you test backuppc?
✅ Formalities