nfs-kernel-server: fix segfault on x86_64#2842
Closed
flyn-org wants to merge 1 commit intoopenwrt:for-15.05from
Closed
nfs-kernel-server: fix segfault on x86_64#2842flyn-org wants to merge 1 commit intoopenwrt:for-15.05from
flyn-org wants to merge 1 commit intoopenwrt:for-15.05from
Conversation
Signed-off-by: W. Michael Petullo <mike@flyn.org>
Member
|
Hi @MikePetullo, |
| .ai_protocol = (int)IPPROTO_UDP, | ||
| .ai_flags = AI_NUMERICHOST, | ||
| .ai_family = AF_UNSPEC, | ||
| + .ai_socktype = 0, |
Member
There was a problem hiding this comment.
this is not guarded with "#ifndef UCLIBC", is this intentional, is this really needed?
Contributor
There was a problem hiding this comment.
It is not needed but does not harm either. When using named struct initializers, then fields not explicitely mentioned are guaranteed to be initialized with zero.
Member
|
Also your commit message doesn't mention uclibc when your commit is uclibc specific |
Member
|
merged in df9eb01 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I previously made this pull request against master (#2568). That was a mistake because master uses musl. 15.05 still uses uclibc, so it requires this patch.
Signed-off-by: W. Michael Petullo mike@flyn.org