libfastjson: add missing runtime dependency on libm#29161
Open
micpf wants to merge 1 commit intoopenwrt:masterfrom
Open
libfastjson: add missing runtime dependency on libm#29161micpf wants to merge 1 commit intoopenwrt:masterfrom
micpf wants to merge 1 commit intoopenwrt:masterfrom
Conversation
micpf
force-pushed
the
fix/libfastjson-add-libm-dependency
branch
from
e581d8b to
69bb2bf
Compare
Contributor
|
Should be conditional for glibc. musl conains math and pth in one lib. |
Contributor
|
+USE_GLIBC:libm |
micpf
force-pushed
the
fix/libfastjson-add-libm-dependency
branch
from
69bb2bf to
5166790
Compare
libfastjson uses modf() from libm but does not declare the dependency. With BIND_NOW (CONFIG_PKG_RELRO_FULL), this can cause the dynamic linker to process libfastjson's relocations before libm's GOT is set up, triggering a crash in libm's IFUNC resolver on PowerPC. Fixes: openwrt#29160 Signed-off-by: micpf <micpf@westermo.com>
micpf
force-pushed
the
fix/libfastjson-add-libm-dependency
branch
from
5166790 to
efa7857
Compare
Contributor
Author
|
ok thanks for the info, I've fixed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libfastjson uses
modf()from libm but does not declare the dependency in its package definition. WithCONFIG_PKG_RELRO_FULL(BIND_NOW), this can cause the dynamic linker to process libfastjson's relocations before libm's GOT is set up, triggering a crash in libm's IFUNC resolver on PowerPC.Observed on PowerPC64 BE (e5500) with glibc 2.41, where rsyslogd crashes immediately on startup.
Fixes: #29160