ddns-scripts: fix incorrect option name in updater messages#29208
Open
dhrm1k wants to merge 3 commits intoopenwrt:masterfrom
Open
ddns-scripts: fix incorrect option name in updater messages#29208dhrm1k wants to merge 3 commits intoopenwrt:masterfrom
dhrm1k wants to merge 3 commits intoopenwrt:masterfrom
Conversation
3 tasks
dhrm1k
force-pushed
the
ddns-updater-legacy-syntax-hint-master-fix
branch
from
7c46801 to
aae0e0a
Compare
Author
|
Last workflow failed because i forgot to add |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates dynamic_dns_updater.sh user-facing text so documentation/error output matches the actual accepted options (replacing the incorrect -N reference with -S), aligning with the script’s option parsing and fixing issue #27737.
Changes:
- Fix help/usage text to remove the incorrect
-Nreference - Fix missing-option error message to reference
-Sinstead of-N
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Please bump PKG_RELEASE by one. |
On master, updater help and missing-option text still refer to '-N'. Use '-S' instead so the messages match accepted script options. This is a text-only change; runtime behavior is unchanged. Fixes: openwrt#27737 Signed-off-by: Dharmik Parmar <dharmikparmar2004@yahoo.com>
The updater -h help text was tautological after replacing -N with -S and no longer explained what value to pass to -S. Added that. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Dharmik Parmar <dharmikparmar2004@yahoo.com>
Bump PKG_RELEASE to 4 to cover the recent updater help text fixes. Signed-off-by: Dharmik Parmar <dharmikparmar2004@yahoo.com>
dhrm1k
force-pushed
the
ddns-updater-legacy-syntax-hint-master-fix
branch
from
5a2a227 to
2dcc6a5
Compare
Author
|
@feckert i have bumped the pkg_release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On master, updater help and missing-option text still refer to '-N'. Use '-S' instead so the messages match accepted script options. This is a text-only change; runtime behavior is unchanged.
Fixes: #27737
📦 Package Details
Maintainer: @feckert
Description:
Update wording in
net/ddns-scripts/files/usr/lib/ddns/dynamic_dns_updater.sh:-Nreference-N->-SNo parser/runtime logic changes are introduced.
🧪 Run Testing Details
Manual CLI checks:
/usr/lib/ddns/dynamic_dns_updater.sh-> missing-S/usr/lib/ddns/dynamic_dns_updater.sh -h-> help reflects-S/usr/lib/ddns/dynamic_dns_updater.sh -N foo-> invalid option-N/usr/lib/ddns/dynamic_dns_updater.sh -S-> missing arg for-S✅ Formalities
If your PR contains a patch:
git ammake package/<your-package>/refresh V=s(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.