Skip to content

coova-chilli: Fix UCI parse error#2934

Merged
champtar merged 1 commit into
openwrt:masterfrom
rajanvaja:chilli
Jul 11, 2016
Merged

coova-chilli: Fix UCI parse error#2934
champtar merged 1 commit into
openwrt:masterfrom
rajanvaja:chilli

Conversation

@rajanvaja
Copy link
Copy Markdown
Contributor

Maintainer: @kaloz

UCI commands report errors in parsing coova-chilli
sample configuration file. This PR fixes this issue by using
proper format in configuration.

Signed-off-by: Rajan Vaja rajan.vaja@gmail.com

@thess
Copy link
Copy Markdown
Member

thess commented Jul 10, 2016

Hi @rajanvaja
Please read and follow PR guidelines: https://github.com/openwrt/packages/blob/master/CONTRIBUTING.md

Minimally you need to bump PKG_RELEASE for the config file change. Is there a dependency on #2737?

@champtar / @kaloz

UCI commands report errors in parsing coova-chilli
sample configuration file. Fix this issue by using
proper format in configuration.

Signed-off-by: Rajan Vaja <rajan.vaja@gmail.com>
@rajanvaja
Copy link
Copy Markdown
Contributor Author

Hi @thess

Thanks for pointing out. I have updated PR with PKG_RELEASE change.

This PR has no dependency on #2737 .

Thanks,
Rajan

@rajanvaja
Copy link
Copy Markdown
Contributor Author

Hi @hojuruku

I think these this PR and #2737 are independent and can be merged individually. is there any reason to merge both PRs?

Thanks,
Rajan

@champtar
Copy link
Copy Markdown
Member

@hojuruku #2737 is not ready to merge
this one is simple and ready to merge, so not waiting for @kaloz

@champtar champtar merged commit 758153e into openwrt:master Jul 11, 2016
@rajanvaja rajanvaja deleted the chilli branch July 11, 2016 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants