treewide: add or correct license information#29440
Conversation
Yang-Wei-Ting
force-pushed
the
license
branch
3 times, most recently
from
efaea0b to
8618bab
Compare
|
Acked-by: Heinrich Schuchardt xypron.glpk@gmx.de |
|
@Yang-Wei-Ting I'd personally prefer if you'd make per-package PRs - this makes it easier to find out where a maintainer should be looking at and, if there are errors introduced with this one, reverting a per-package PR is much cleaner :-) Edit: also, approving this cross-package PR is like approving changes for packages one does not maintain... |
|
Hi @bk138, I understand the preference for per-package PRs, and I can see the advantages regarding review scope. That said, I also know there are OpenWrt members (GeorgeSapkin, for example) who prefer a single treewide commit to avoid unnecessary repository noise, and I tend to agree with that approach for mechanical fixes like these. If it would make review easier, I can split out the packages you maintain into a separate PR. I'd just prefer to avoid opening 40 individual PRs for what is essentially the same class of license fixes across the tree. :) |
|
@Yang-Wei-Ting I understand, thanks for clarifying. LGTM for gzip :-) |
Yang-Wei-Ting
force-pushed
the
license
branch
2 times, most recently
from
7b44801 to
334e27c
Compare
|
@Yang-Wei-Ting would you consider adding the missing version check overrides as well for the packages that fail the generic version check? |
| PKG_MAINTAINER:=Imre Kaloz <kaloz@openwrt.org>, \ | ||
| Hsing-Wang Liao <kuoruan@gmail.com> | ||
| PKG_LICENSE:=GPLv2 | ||
| PKG_LICENSE:=LicenseRef-Callaway-GPLv2+-with-exceptions |
There was a problem hiding this comment.
Where is this coming from?
There was a problem hiding this comment.
There was a problem hiding this comment.
Is this not something Fedora-specific? The license looks like GPL 2.0:
There was a problem hiding this comment.
I would try if there's an example. |
|
Check out this PR for some examples: |
Yang-Wei-Ting
force-pushed
the
license
branch
2 times, most recently
from
dd408f1 to
f45bd7f
Compare
Add or correct license information across multiple packages. Signed-off-by: Wei-Ting Yang <williamatcg@gmail.com>
Add version check override script. Signed-off-by: Wei-Ting Yang <williamatcg@gmail.com>
Add version check override script. Signed-off-by: Wei-Ting Yang <williamatcg@gmail.com>
Add version check override script. Signed-off-by: Wei-Ting Yang <williamatcg@gmail.com>
Add version check override script. Signed-off-by: Wei-Ting Yang <williamatcg@gmail.com>
Add version check override script. Signed-off-by: Wei-Ting Yang <williamatcg@gmail.com>
7 participants
📦 Package Details
Maintainer: @Noltari, @Thermi, @Zokormazo, @bk138, @bmork, @commodo, @dangowrt, @flyn-org, @graysky2, @hnyman, @jow-, @kaloz, @kuoruan, @nbd168, @neheb, @obsy, @pkerling, @pprindeville, @robimarko, @salzmdan, @stintel, @thess, @urusha, @val-kulkov, @xypron, @yousong
Description:
Add or correct license information across multiple packages.
✅ Formalities