jail: mount ucode related bits into netifd jail#34
Open
dhewg wants to merge 4 commits intoopenwrt:mainfrom
Open
jail: mount ucode related bits into netifd jail#34dhewg wants to merge 4 commits intoopenwrt:mainfrom
dhewg wants to merge 4 commits intoopenwrt:mainfrom
Conversation
netifd gained ucode support, mount the required pieces to fix the
errors:
daemon.crit netifd: Error loading ucode script:
Syntax error: Unable to resolve path for module 'uci' In line 1, byte 27:
`import * as uci from "uci";`
Near here ----------------^
Syntax error: Unable to resolve path for module 'uloop' In line 2, byte 31:
`import * as uloop from "uloop";`
Near here --------------------^
Syntax error: Unable to resolve path for module 'ubus' In line 3, byte 32:
`import * as libubus from "ubus";`
Near here ---------------------^
Syntax error: Unable to resolve path for module 'fs' In line 4, byte 37:
`import { access, dirname } from "fs";`
Near here --------------------------^
Signed-off-by: Andre Heider <a.heider@gmail.com>
Member
|
1st commit is fine and can go in. |
This spams the logs with every in- and outcoming byte. Signed-off-by: Andre Heider <a.heider@gmail.com>
Author
|
Thanks, sounds good, done!
|
Author
|
Added two more patches by now, let me know if I should split into multiple PRs instead
|
Member
|
I appreciate the bug fix, but even if it seems trivial, please write a short commit message, not just the title. |
./dhcp.sh: eval: line 33: md5sum: not found ./dhcp.sh: eval: line 33: cut: not found ./dhcp.sh: eval: line 107: /sbin/uci: not found /bin/ipcalc.sh: line 5: basename: not found /bin/ipcalc.sh: line 5: basename: not found Signed-off-by: Andre Heider <a.heider@gmail.com>
Fix the typo to properly set the device group in the container namespace. Signed-off-by: Andre Heider <a.heider@gmail.com>
Author
|
Turns out |
dangowrt
pushed a commit
to dhewg/openwrt
that referenced
this pull request
Apr 24, 2026
The netifd/dhcp flow uses this, and as uxc mounts netifd in a container, this allows not mounting `basename` for just a usage. References: openwrt/procd#34 Suggested-by: Daniel Golle <daniel@makrotopia.org> Signed-off-by: Andre Heider <a.heider@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
netifd gained ucode support on master, adapt the bind mounts so it works in a jail again.
While at it, the second patch disables the excessive uxc console logging.
/cc @dangowrt @aparcar
Related question:
With a self-built image from the main branch my veth setup doesn't come up automatically, I have to run
ubus call network.interface.virt0 upfirst to make it work. Is that my setup or another difference between stable/main?