Merged
Conversation
Contributor
Author
|
ping @jslachta |
Contributor
|
I did the same just yesterday ;) It may be worth mentioning the fixed CVEs?
I also have this, and I wouldn't mind if you just include it in your PR:
a354559
|
dropped patch 001 - integrated at source all patches refreshed Signed-off-by: Paul Donald <newtwen+github@gmail.com>
A module is either essential (shipped as part of the main package) or as a seperate package. Having both is an install-time conflict. res-timing-timerfd is an essential module and was correctly added to the main package with e538fc3. Remove the additional one. app_stack is non-essential and was added to the main package as part of the app_macro removal with 73fd665. Make it optional again. Signed-off-by: Andre Heider <a.heider@gmail.com>
Remove redundant empty lines and refactor the logging. It can now be used for any level. Signed-off-by: Andre Heider <a.heider@gmail.com>
`/etc/init.d/asterisk reregister` will re-register all outbound registrations. Currently only pjsip is supported, but, if required, this can be easily extended in the future. Signed-off-by: Andre Heider <a.heider@gmail.com>
If set this now automatically re-registers all outbound registrations when the interface is becoming available. This ensures that no stale IPs are registered at the SIP trunk. Fixes openwrt#681 Signed-off-by: Andre Heider <a.heider@gmail.com>
Contributor
Author
|
Shall I throw everything else in there? |
Contributor
|
Shall I throw everything else in there?
Oh, you just took 'em all, hah!
For this bump I'd really just add the single commit I pointed to, as it fixes actual package bugs.
The other stuff is still useful IMHO, but:
I had a PR about these a few years ago, but they were rejected:
asterisk: clean up init.d script
asterisk: add a reregister extra command
asterisk: add an 'interface' option to trigger reregister events
These two patch asterisk, but as I won't sign upstream's agreement they won't be merged there and hence we need to maintain them if accepted:
asterix: fix build with CONFIG_OPENSSL_NO_DEPRECATED
asterisk: VM_MESSAGEFILE
Which is why they don't have a proper commit message and are not even signed off...
|
Contributor
Author
|
We’re basically carrying the other patches in perpetua … |
Contributor
Author
|
ping... @Ansuel ? |
Contributor
|
Hi @systemcrash , the last commit - asterix: fix build with CONFIG_OPENSSL_NO_DEPRECATED - fails on formalities - missing SoB line. Otherwise, it looks good to me. Thank you so much! I am sorry for the delay. |
Signed-off-by: Andre Heider <a.heider@gmail.com> Signed-off-by: Paul Donald <newtwen+github@gmail.com>
Signed-off-by: Andre Heider <a.heider@gmail.com> Signed-off-by: Paul Donald <newtwen+github@gmail.com>
Contributor
Author
|
OK - fixed those. |
Contributor
|
It fails on formalities. I am merging this anyway. Thank you so much for your hard work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dropped patch 001 - integrated at source
all patches refreshed