chore(subos): silence storage-dormant hint on shell-level entry#294
Merged
Conversation
The hint "[xlings] storage=X is sandbox-only; entering shell-level (use --sandbox to activate)" had two UX issues: - Ambiguous wording: "use --sandbox to activate" reads as either the verb or the `xlings subos use` command name; "activate" doesn't say what gets activated (the storage isolation). - Noisy: fires on every shell-level entry into an image/tmpfs subos, even after the user already knows the layout. Comment out the println for now; the call site (warn_storage_dormant_on_shell_) is kept so we can drop in a clearer one-time / opt-in form later without restructuring the callers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
warn_storage_dormant_on_shell_()里的 stderr 提示起因
当前提示:
两个问题:
use --sandbox to activate在中英文里都容易被读成动词 vsxlings subos use命令名;activate没说激活的是 storage 隔离。状态
Draft — 暂不合入,先放着观察一下要不要顺手做更彻底的 UX 改造(一次性提示 / 仅在
--verbose下打 / 重写措辞)再决定合或者重写。Test plan
xlings subos use <image-subos>不再打出 hintxlings subos use <image-subos> --sandbox行为不变xlings subos use <shared-subos>行为不变(原本就 early-return)