Skip to content

[codex] fix config install state and Windows installer probing#306

Merged
Sunrisepeak merged 4 commits into
mainfrom
codex/config-install-dir-no-implicit-create
May 26, 2026
Merged

[codex] fix config install state and Windows installer probing#306
Sunrisepeak merged 4 commits into
mainfrom
codex/config-install-dir-no-implicit-create

Conversation

@Sunrisepeak
Copy link
Copy Markdown
Member

@Sunrisepeak Sunrisepeak commented May 26, 2026

Summary

  • keep type=config packages repeatable when they do not create their own payload
  • stop xlings from making config packages look installed via the automatic .xim-installed stamp or .xpkg.lua snapshot
  • update the Windows quick installer to use only two release source families: official GitHub and GitCode xlings-res/xlings
  • probe release metadata latency and prefer the lower-latency source among candidates for the selected version
  • avoid exit in the Windows irm | iex installer path; failures now log and throw instead of terminating the caller PowerShell host directly

Root Cause

Config package installed state is based on install_dir being a non-empty directory. The previous behavior wrote xlings-owned content into an otherwise empty config install dir after the install hook, so a repeatable config package could be treated as already installed on the next run. The fix keeps the normal install dir setup, but skips xlings-owned installed markers/snapshots for config packages.

The Windows quick installer previously resolved and downloaded from a single GitHub URL. On query/download/extract failure it called exit 1; in the one-line irm ... | iex flow that can terminate the caller PowerShell session/window. The installer now probes GitHub and GitCode metadata latency, keeps the highest available version when no version is specified, then downloads from the lower-latency candidate for that version with fallback on download failure.

Verification

  • git diff --check
  • xmake build xlings
  • bash tests/e2e/config_install_no_implicit_dir_test.sh
  • bash tests/e2e/windows_quick_install_resource_probe_test.sh
  • release-resource probes with gh release view and GitCode API checks

@Sunrisepeak Sunrisepeak force-pushed the codex/config-install-dir-no-implicit-create branch from abb018c to df22604 Compare May 26, 2026 18:59
@Sunrisepeak Sunrisepeak force-pushed the codex/config-install-dir-no-implicit-create branch from df22604 to 70d9d09 Compare May 26, 2026 19:22
@Sunrisepeak Sunrisepeak changed the title [codex] fix implicit config install dirs [codex] fix config install state and Windows installer probing May 26, 2026
@Sunrisepeak Sunrisepeak force-pushed the codex/config-install-dir-no-implicit-create branch from 70d9d09 to 0d0cd59 Compare May 26, 2026 19:27
@Sunrisepeak Sunrisepeak force-pushed the codex/config-install-dir-no-implicit-create branch from af54050 to 9139108 Compare May 26, 2026 20:33
@Sunrisepeak Sunrisepeak marked this pull request as ready for review May 26, 2026 21:11
@Sunrisepeak Sunrisepeak merged commit a4cb2db into main May 26, 2026
3 checks passed
@Sunrisepeak Sunrisepeak deleted the codex/config-install-dir-no-implicit-create branch May 26, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant