[codex] fix config install state and Windows installer probing#306
Merged
Conversation
abb018c to
df22604
Compare
df22604 to
70d9d09
Compare
70d9d09 to
0d0cd59
Compare
af54050 to
9139108
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
type=configpackages repeatable when they do not create their own payload.xim-installedstamp or.xpkg.luasnapshotxlings-res/xlingsexitin the Windowsirm | iexinstaller path; failures now log and throw instead of terminating the caller PowerShell host directlyRoot Cause
Config package installed state is based on
install_dirbeing a non-empty directory. The previous behavior wrote xlings-owned content into an otherwise empty config install dir after the install hook, so a repeatable config package could be treated as already installed on the next run. The fix keeps the normal install dir setup, but skips xlings-owned installed markers/snapshots for config packages.The Windows quick installer previously resolved and downloaded from a single GitHub URL. On query/download/extract failure it called
exit 1; in the one-lineirm ... | iexflow that can terminate the caller PowerShell session/window. The installer now probes GitHub and GitCode metadata latency, keeps the highest available version when no version is specified, then downloads from the lower-latency candidate for that version with fallback on download failure.Verification
git diff --checkxmake build xlingsbash tests/e2e/config_install_no_implicit_dir_test.shbash tests/e2e/windows_quick_install_resource_probe_test.shgh release viewand GitCode API checks