Display quarantine, staging, needs_file_operation and has_error books in inbox

[benoit74]

In the Inbox tab, we want to display all books which require user attention.

This means quarantine (as of today) and staging (to be added) books.

Also display there books which needs a file operation (even if they do not require user action, but having them centralized in a single view is convenient) and books which have errors.

Books should be sorted for better readability:

• first by status: has_error then quarantine then staging then needs_file_operation
• then by created_at (descending, i.e. most recent books first)

[benoit74]

Note that it means we should probably:

• add new filter(s) to the view
• display deletion_date in the table when present

[benoit74]

I reopen because I thought at first glance that #210 condition "has no title" was correct but it is not : books in staging have a title, do not need processing or file operation, and have no error.

We hence need to replace the "has no title" condition with "location_kind == staging or location_kind == quarantine".

@elfkuzco is this something you have time to do shortly or may I proceed (I don't mind tbh)

[elfkuzco]

I will work on it.

[elfkuzco]

books in staging have a title, do not need processing or file operation, and have no error.
We hence need to replace the "has no title" condition with "location_kind == staging or location_kind == quarantine".

Does this not mean that "has no title" will return books in "prod"?

[elfkuzco]

Actually, wouldn't it be better to pass the exact location kinds in the query. My understanding is that we want the condition to be re-written as:

    if has_title is not None:
        if has_title:
            stmt = stmt.where(Book.title_id.is_not(None))
        else:
            stmt = stmt.where(Book.location_kind.in_(["staging", "quarantine"]))

If that's correct, then, isn't that misleading?

[benoit74]

My point is not about this "has title" API condition, but rather about needs_attention API condition (which is used to populate this view). Sorry for not being precise enough, my point was indeed misleading.

    if needs_attention is True:
        stmt = stmt.where(
            or_(
                Book.location_kind.in_(["quarantine", "staging"]) # <== New
                Book.title_id.is_(None),
                Book.needs_processing.is_(True),
                Book.needs_file_operation.is_(True),
                Book.has_error.is_(True),
            )
        )
    elif needs_attention is False:
        stmt = stmt.where(
            and_(
                Book.location_kind.not_in(["quarantine", "staging"]) # <== New
                Book.title_id.is_not(None),
                Book.needs_processing.is_(False),
                Book.needs_file_operation.is_(False),
                Book.has_error.is_(False),
            )
        )