query db for latest books during zim URL computation#262
Open
query db for latest books during zim URL computation#262
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #262 +/- ##
==========================================
- Coverage 81.41% 81.38% -0.04%
==========================================
Files 53 53
Lines 2228 2235 +7
Branches 216 218 +2
==========================================
+ Hits 1814 1819 +5
Misses 357 357
- Partials 57 59 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR refactors the way zim URLs are computed by using a subquery to get the books which are the latest per title/flavor combination. It then joins this subquery to the original query and building up a column
is_latestif the current book date matches the one from the latest subquery. This way, we can/cannot have a view URL depending on if the latest book is included in the book IDs to compute their URL.Changes
is_latestpropertyDatefirst beforecreated_at. This will fix the issue in Computation of ZIM to view has a bug when title changed #253This fixes #253
This fixes #254