Skip to content

rename user to account#263

Merged
elfkuzco merged 1 commit intomainfrom
user-to-account
May 4, 2026
Merged

rename user to account#263
elfkuzco merged 1 commit intomainfrom
user-to-account

Conversation

@elfkuzco
Copy link
Copy Markdown
Contributor

Rationale

This PR renames user to account across the codebase

Changes

  • create migration to rename table from user to account along with renames and recreating constraints
  • rename route from /users to /accounts
  • replace word user with account across all functions and files

This closes #242

@elfkuzco elfkuzco self-assigned this Apr 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 77.30061% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.06%. Comparing base (b78d74a) to head (7679e12).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
backend/src/cms_backend/api/token.py 38.46% 13 Missing and 3 partials ⚠️
backend/src/cms_backend/api/routes/account.py 86.95% 5 Missing and 1 partial ⚠️
backend/src/cms_backend/api/routes/dependencies.py 75.00% 2 Missing and 3 partials ⚠️
backend/src/cms_backend/utils/database.py 28.57% 5 Missing ⚠️
backend/src/cms_backend/api/routes/auth.py 60.00% 4 Missing ⚠️
backend/src/cms_backend/api/main.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #263      +/-   ##
==========================================
- Coverage   81.41%   81.06%   -0.36%     
==========================================
  Files          53       53              
  Lines        2228     2239      +11     
  Branches      216      219       +3     
==========================================
+ Hits         1814     1815       +1     
- Misses        357      365       +8     
- Partials       57       59       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@elfkuzco
Copy link
Copy Markdown
Contributor Author

It appears black is formatting a line and still it's greater than 88 characters whereas Ruff does the right thing. Upgraded black manually and ran with black --line-length=88 src/api/token.py and it still produces line with 90 characters long. @benoit74 , should we use ruff only?

@elfkuzco elfkuzco requested a review from benoit74 April 29, 2026 13:09
@benoit74
Copy link
Copy Markdown
Contributor

benoit74 commented May 4, 2026

It appears black is formatting a line and still it's greater than 88 characters whereas Ruff does the right thing. Upgraded black manually and ran with black --line-length=88 src/api/token.py and it still produces line with 90 characters long. @benoit74 , should we use ruff only?

This is the same problem I've experienced on Zimfarm. Did you check if there is not simply something wrong in black usage? (maybe we are not using the right parameter anymore ...)

Copy link
Copy Markdown
Contributor

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@elfkuzco elfkuzco force-pushed the user-to-account branch from 7ece986 to 7679e12 Compare May 4, 2026 09:40
@elfkuzco elfkuzco merged commit d8d6b94 into main May 4, 2026
6 of 9 checks passed
@elfkuzco elfkuzco deleted the user-to-account branch May 4, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move from user to account

2 participants