Skip to content

show button to configure 2FA on Ory#276

Merged
elfkuzco merged 1 commit into
mainfrom
2fa-config-button
May 11, 2026
Merged

show button to configure 2FA on Ory#276
elfkuzco merged 1 commit into
mainfrom
2fa-config-button

Conversation

@elfkuzco
Copy link
Copy Markdown
Contributor

Rationale

Screenshot_20260511_100007

Changes

  • add button to configure 2FA on Ory
  • hide button to sign in when error is 2FA error
  • fix bug in local token decoder always returning true for can_decode

@elfkuzco elfkuzco self-assigned this May 11, 2026
@elfkuzco elfkuzco requested a review from benoit74 May 11, 2026 09:02
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.30%. Comparing base (5aab3c6) to head (cd6dde8).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
backend/src/cms_backend/api/token.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
- Coverage   81.49%   81.30%   -0.20%     
==========================================
  Files          55       55              
  Lines        2356     2364       +8     
  Branches      233      235       +2     
==========================================
+ Hits         1920     1922       +2     
- Misses        377      381       +4     
- Partials       59       61       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much for the proactive change linked to Zimfarm changes!

@elfkuzco elfkuzco force-pushed the 2fa-config-button branch from 04b71eb to cd6dde8 Compare May 11, 2026 09:34
@elfkuzco elfkuzco merged commit 07bdcaa into main May 11, 2026
4 of 7 checks passed
@elfkuzco elfkuzco deleted the 2fa-config-button branch May 11, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants