Skip to content

view books and update book flavour#299

Merged
elfkuzco merged 1 commit into
mainfrom
book-views
May 26, 2026
Merged

view books and update book flavour#299
elfkuzco merged 1 commit into
mainfrom
book-views

Conversation

@elfkuzco
Copy link
Copy Markdown
Contributor

Rationale

This PR enhances the UI to have a dedicated books view (different from the books tab in the Inbox view). Whereas the books in the inbox tab are set to fetch books that "need attention", the books view allows user to fetch even those that do not, along with newer filters. The PR also adds capability to update a book's flavour

Screenshot_20260526_120640 Screenshot_20260526_120620

Changes

  • create dedicated book view for listing all books
  • add capability to edit book flavour via API/UI
  • create different set of filters for the new book view differnt from the inbox view filters

This closes #293

@elfkuzco elfkuzco self-assigned this May 26, 2026
@elfkuzco elfkuzco requested a review from benoit74 May 26, 2026 11:15
@elfkuzco
Copy link
Copy Markdown
Contributor Author

Not sure why CI isn't running checks...

@benoit74
Copy link
Copy Markdown
Contributor

You should try to amend commit (with nothing different, just a new commit ID) and push again. Probably a bug githubside.

Copy link
Copy Markdown
Contributor

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check CI is green and then you can merge, LGTM

@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

❌ Patch coverage is 88.23529% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.60%. Comparing base (a61b6be) to head (156e466).

Files with missing lines Patch % Lines
backend/src/cms_backend/db/books.py 42.85% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
+ Coverage   81.52%   81.60%   +0.08%     
==========================================
  Files          58       58              
  Lines        2571     2604      +33     
  Branches      259      264       +5     
==========================================
+ Hits         2096     2125      +29     
- Misses        405      407       +2     
- Partials       70       72       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@elfkuzco elfkuzco merged commit 4f0bf5f into main May 26, 2026
7 checks passed
@elfkuzco elfkuzco deleted the book-views branch May 26, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

View all books, filter them and edit book flavour

2 participants