Skip to content

Fix logic computing label for places discrimination#101

Open
benoit74 wants to merge 1 commit intomainfrom
fix_place_discrimination
Open

Fix logic computing label for places discrimination#101
benoit74 wants to merge 1 commit intomainfrom
fix_place_discrimination

Conversation

@benoit74
Copy link
Copy Markdown
Collaborator

@benoit74 benoit74 commented Apr 20, 2026

Fix #93

Changes:

@benoit74 benoit74 self-assigned this Apr 20, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

❌ Patch coverage is 88.52459% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.60%. Comparing base (3989d9f) to head (18fe0bd).

Files with missing lines Patch % Lines
scraper/src/maps2zim/processor.py 88.52% 1 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   33.23%   35.60%   +2.37%     
==========================================
  Files          11       11              
  Lines         981     1025      +44     
  Branches      129      145      +16     
==========================================
+ Hits          326      365      +39     
  Misses        644      644              
- Partials       11       16       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benoit74
Copy link
Copy Markdown
Collaborator Author

Downside of this PR is #102

@benoit74 benoit74 force-pushed the fix_place_discrimination branch from 9a69205 to 18fe0bd Compare April 20, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not introduce "false duplicates" in suggestions index / disambiguation pages

1 participant