Skip to content

Add all possibilites in suggestion index when disambiguation page is used#103

Merged
benoit74 merged 1 commit intomainfrom
ambiguities-in-index
Apr 20, 2026
Merged

Add all possibilites in suggestion index when disambiguation page is used#103
benoit74 merged 1 commit intomainfrom
ambiguities-in-index

Conversation

@benoit74
Copy link
Copy Markdown
Collaborator

Fix #92

Changes:

  • create an entry in title index for all places even in case of ambiguity
  • add (disambiguation) suffix to the disambiguation page title

@benoit74 benoit74 self-assigned this Apr 20, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 20, 2026

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.23%. Comparing base (5d18c5b) to head (b7faf36).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/maps2zim/processor.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   33.29%   33.23%   -0.07%     
==========================================
  Files          11       11              
  Lines         979      981       +2     
  Branches      128      129       +1     
==========================================
  Hits          326      326              
- Misses        642      644       +2     
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benoit74 benoit74 force-pushed the ambiguities-in-index branch from 7ae3219 to b7faf36 Compare April 20, 2026 12:51
@benoit74 benoit74 merged commit 3989d9f into main Apr 20, 2026
10 checks passed
@benoit74 benoit74 deleted the ambiguities-in-index branch April 20, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add all possibilites in suggestion index when disambiguation page is used

1 participant