Skip to content

Do not add duplicate search entries#108

Merged
benoit74 merged 1 commit intomainfrom
no_duplicate_entry
Apr 28, 2026
Merged

Do not add duplicate search entries#108
benoit74 merged 1 commit intomainfrom
no_duplicate_entry

Conversation

@benoit74
Copy link
Copy Markdown
Collaborator

Fix #107

This issue fixes the scraper failure so that at least we achieve to produce a valid ZIM. It does not fixes the problem itself which is that we miss hierarchy information for these places. I will open a distinct issue on that topic

@benoit74 benoit74 self-assigned this Apr 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.33%. Comparing base (355112a) to head (5827993).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/maps2zim/processor.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   35.60%   35.33%   -0.28%     
==========================================
  Files          11       11              
  Lines        1025     1033       +8     
  Branches      145      147       +2     
==========================================
  Hits          365      365              
- Misses        644      652       +8     
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benoit74 benoit74 force-pushed the no_duplicate_entry branch from 6468b4c to 5827993 Compare April 28, 2026 13:33
@benoit74 benoit74 merged commit d213e5d into main Apr 28, 2026
10 checks passed
@benoit74 benoit74 deleted the no_duplicate_entry branch April 28, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scraper fails trying to add two ZIM items with same title

1 participant