Set the maximum zoom level to 18 (20m/50ft) in map configuration

[AdeelTahir-SE]

Fixed issue #86
Set the maximum zoom level to 18 (20m/50ft), as going further deep does not translate to better view

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.33%. Comparing base (a4c6ade) to head (95c1e7a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #87   +/-   ##
=======================================
  Coverage   33.33%   33.33%           
=======================================
  Files          11       11           
  Lines         981      981           
  Branches      133      133           
=======================================
  Hits          327      327           
  Misses        643      643           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[benoit74]

And where does the 18 magic number comes from? (no need to write this is source code but justifying the choice in the PR would help).

[benoit74]

Regarding max zoom, I barely understand your logic because we do not ZIM only Monaco region but the whole world. We hence need something OK (or okayish at least) for the whole world.

Since issue reported compared with https://www.openstreetmap.org/, what is the max zoom level over there? Can you find where and why they made this choice?

[AdeelTahir-SE]

The maximum zoom level in OpenStreetMap is not the same everywhere; it varies by region. For example, in Monaco the maximum visible resolution is around 20 m, whereas in Alexander Island it is around 5 m. This variation is partly due to differences in latitude, as different latitudes produce different ground resolutions at the same zoom level.

In issue #86, the example used Monaco, where the maximum zoom corresponds to 20 m. Based on that, I experimented with different maxZoom values and found that setting maxZoom = 18 produces this level of detail for Monaco. Testing the same for Alexander Island in Antarctica gave a maximum visible resolution of 5 m, consistent with OpenStreetMap.

It is also important to note that the zoom level depends on the tile type (vector vs raster). In our case, we are using vector tiles from OpenMapTiles, and with this configuration, maxZoom = 18 appears to be the most appropriate setting.

[AdeelTahir-SE]

Also according to my research OpenStreetMap is using maxZoom of 19 with raster tiles which will be equivalent to our maxZoom of 18 as we are using vector tiles instead of Raster tiles, which (vector tiles) provides roughly the same effective ground resolution as zoom 19 in the raster tiles.

[benoit74]

The maximum zoom level in OpenStreetMap is not the same everywhere; it varies by region. For example, in Monaco the maximum visible resolution is around 20 m, whereas in Alexander Island it is around 5 m. This variation is partly due to differences in latitude, as different latitudes produce different ground resolutions at the same zoom level.

To me this does not indicate that max zoom level is not the same everywhere. It even kinda indicate the opposite: max zoom level is the same everywhere but due to latitude it does not produce the same maximum "resolution".

It is also important to note that the zoom level depends on the tile type (vector vs raster). In our case, we are using vector tiles from OpenMapTiles, and with this configuration, maxZoom = 18 appears to be the most appropriate setting.

I don't get this. Vector or raster, what is displayed is the same thing, only "encoding" changes.

Also according to my research OpenStreetMap is using maxZoom of 19 with raster tiles which will be equivalent to our maxZoom of 18 as we are using vector tiles instead of Raster tiles, which (vector tiles) provides roughly the same effective ground resolution as zoom 19 in the raster tiles.

Again I don't get this logic.

In issue #86, the example used Monaco, where the maximum zoom corresponds to 20 m. Based on that, I experimented with different maxZoom values and found that setting maxZoom = 18 produces this level of detail for Monaco. Testing the same for Alexander Island in Antarctica gave a maximum visible resolution of 5 m, consistent with OpenStreetMap.

Saying this from the very beginning would have been sufficient. LGTM, thank you.

Please:

• squash your commits
• fix the CHANGELOG content which mention zoom level 20?

[AdeelTahir-SE]

All requested changes are done: commits squashed and CHANGELOG updated. Ready for final review.

[benoit74]

For some reason, there is still 2 commits (including an unrelated one) to merge. Can you please check?

[AdeelTahir-SE]

My requested changes (commits squashed and CHANGELOG updated) are complete.
The extra commit (Add default ZIM tags based on Kiwix convention) was authored by you,which is unrelated to my work.
Please let me know if anything else is needed from my side.

For some reason, there is still 2 commits (including an unrelated one) to merge. Can you please check?

[benoit74]

Your PR should not contain commits from another PR, especially once they have been merged to main. Here what you missed is a rebase. I've done it, thank you.

[benoit74]

LGTM