Skip to content

Correctly bundle ZIM UI inside the pip package#88

Merged
benoit74 merged 1 commit intomainfrom
zim_ui_pkg
Apr 7, 2026
Merged

Correctly bundle ZIM UI inside the pip package#88
benoit74 merged 1 commit intomainfrom
zim_ui_pkg

Conversation

@benoit74
Copy link
Copy Markdown
Collaborator

@benoit74 benoit74 commented Apr 7, 2026

Fix #63

@benoit74 benoit74 self-assigned this Apr 7, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.33%. Comparing base (d8cf7ca) to head (c999b51).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage   33.33%   33.33%           
=======================================
  Files          11       11           
  Lines         981      981           
  Branches      133      133           
=======================================
  Hits          327      327           
  Misses        643      643           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benoit74
Copy link
Copy Markdown
Collaborator Author

benoit74 commented Apr 7, 2026

Tested with

> pip install /home/benoit/Repos/openzim/maps/scraper/dist/maps2zim-0.1.2.dev0-py3-none-any.whl
> maps2zim --area monaco --geonames-region MC --name maps-tests_en_all --title "Maps Test" --description "Test ZIM for maps" --file-name "maps-tests_en_all" --default-view=43.74,7.43,13 --tmp /tmp --overwrite --zim-workers 16 
[maps2zim::MainThread::2026-04-07 12:10:47,724] INFO:Generating ZIM
[maps2zim::MainThread::2026-04-07 12:10:47,724] INFO:  Progress 0 / 1
[maps2zim::MainThread::2026-04-07 12:10:47,724] INFO:  Writing to: output/maps-tests_en_all.zim
[maps2zim::MainThread::2026-04-07 12:10:47,724] INFO:  Fetching ZIM illustration...
[maps2zim::MainThread::2026-04-07 12:10:48,002] INFO:  Storing configuration...
[maps2zim::MainThread::2026-04-07 12:10:48,002] INFO:Adding 5 Vue.JS UI files in /tmp/maps/venv/lib/python3.14/site-packages/maps2zim/zimui

=> we do have the expected Vue.JS files

@benoit74 benoit74 merged commit a4c6ade into main Apr 7, 2026
10 checks passed
@benoit74 benoit74 deleted the zim_ui_pkg branch April 7, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pip package is missing the ZIM UI

1 participant