Skip to content

change illustration url flag from url to blob type #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benoit74 merged 1 commit into from
Dec 16, 2025
Merged

change illustration url flag from url to blob type #141

benoit74 merged 1 commit into from
Dec 16, 2025
+2 −1

Conversation

@elfkuzco
Copy link
Contributor

@elfkuzco elfkuzco commented Dec 15, 2025

Rationale

See openzim/zimfarm#1576

Changes

  • change illustration_url flag from url to image blob

@elfkuzco elfkuzco self-assigned this Dec 15, 2025
@elfkuzco elfkuzco requested a review from benoit74 December 15, 2025 12:43
benoit74
benoit74 approved these changes Dec 16, 2025
View reviewed changes
Copy link
Contributor

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoit74 benoit74 merged commit d1909c9 into main Dec 16, 2025
6 of 7 checks passed
@benoit74 benoit74 deleted the blob-types branch December 16, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benoit74 benoit74 benoit74 approved these changes

Assignees

@elfkuzco elfkuzco

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elfkuzco @benoit74