Add support for new illustrations APIs in libzim 9.4.0 #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit74
force-pushed
the
add_illustrations_api
branch
5 times, most recently
from
53b6486 to
4da244a
Compare
benoit74
force-pushed
the
add_illustrations_api
branch
from
4da244a to
070b003
Compare
benoit74
force-pushed
the
add_illustrations_api
branch
3 times, most recently
from
35ad235 to
bfd945f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## libzim_9.4.0 #233 +/- ##
================================================
+ Coverage 93.77% 94.38% +0.60%
================================================
Files 1 1
Lines 546 605 +59
================================================
+ Hits 512 571 +59
Misses 34 34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
benoit74
force-pushed
the
add_illustrations_api
branch
from
bfd945f to
de46d68
Compare
|
Ready for review, wheels build still failing on ubuntu arm64 for "known reasons" but rest is in place so ready to be analyzed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #232
To be merged after #234 (which is simpler / narrower scope)
Changes:
illustrationmodule with theIllustrationInfoclass, used byreaderandwritermodulesreader.Archive.get_illustration_item: get "default" and get specific sizes/scalesreader.Archive.get_illustrations_infoswriter.Creator.add_illustration: pass detailed illustration infos instead of one fixed size