Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
==========================================
+ Coverage 93.77% 94.13% +0.36%
==========================================
Files 1 1
Lines 546 546
==========================================
+ Hits 512 514 +2
+ Misses 34 32 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Looks good ; what's the explanation for the changed test? |
rgaudin
approved these changes
May 19, 2026
Member
rgaudin
left a comment
rgaudin
left a comment
There was a problem hiding this comment.
LGTM ; have you seen my question?
Contributor
Author
|
Oups, PR was not updated with your approval on my side when I requested it ... sorry Tests have been updated because a "clean" ZIM creation now outputs four lines: https://github.com/openzim/libzim/blob/9.7.0/test/creator.cpp#L388-L392 Where it used to output only two. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #254