Properly dealloc creatorWrapper on close #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I am unable to reproduce the failing test, neither on macOS (py38, py36) nor on docker/linux ( |
mgautierfr
suggested changes
Jun 12, 2020
mgautierfr
suggested changes
Jun 15, 2020
Contributor
mgautierfr
left a comment
mgautierfr
left a comment
There was a problem hiding this comment.
The final code is good.
But 7 commits for this is a bit too much :)
And please, rebase on master instead of merging master into the branch.
Member
Author
Yes, the Resolve Conflict button on github is a curse :) Kept the tests in a separate commit though. |
mgautierfr
approved these changes
Jun 15, 2020
Contributor
|
We are good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41 by explicitly deleting the creatorWrapper once we've finalized it on the
Creator.close.Also fixes #31 by calling
close()onCreator(pure-python) deletion