Skip to content

Fix qa#1909

Merged
elfkuzco merged 3 commits into
mainfrom
fix-qa
May 19, 2026
Merged

Fix qa#1909
elfkuzco merged 3 commits into
mainfrom
fix-qa

Conversation

@elfkuzco
Copy link
Copy Markdown
Collaborator

@elfkuzco elfkuzco commented May 19, 2026

Rationale

openzim/_python-bootstrap#56 introduced new changes to improve qa and fix conflicts between ruff and black. This PR ports those changes to the zimfarm components

@elfkuzco elfkuzco self-assigned this May 19, 2026
@elfkuzco elfkuzco requested a review from benoit74 May 19, 2026 10:40
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.76%. Comparing base (34484ef) to head (3141728).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1909   +/-   ##
=======================================
  Coverage   83.76%   83.76%           
=======================================
  Files         101      101           
  Lines        5223     5223           
  Branches      546      546           
=======================================
  Hits         4375     4375           
  Misses        697      697           
  Partials      151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done!

@elfkuzco
Copy link
Copy Markdown
Collaborator Author

elfkuzco commented May 19, 2026

LGTM, well done!

Just did a clean sweep of the word black across the codebase and it seems alembic uses it as a post-write hook for formatting generated files. Upgraded alembic and fixed based on sqlalchemy/alembic#1686

It now uses ruff as post-write hook

@elfkuzco elfkuzco merged commit db5af23 into main May 19, 2026
9 checks passed
@elfkuzco elfkuzco deleted the fix-qa branch May 19, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants