Add tests for response status tracing in Excon middleware #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the response status is correctly traced. Also guard against nil response/status, which might happen if the middleware is inserted into Excon before the Excon::Middleware::ResponseParser.
| end | ||
|
|
||
| def response_status(datum) | ||
| return nil unless datum[:response] && datum[:response][:status] |
Collaborator
There was a problem hiding this comment.
In this case I'd write this slightly simpler:
datum[:response] && datum[:response][:status] && datum[:response][:status].to_s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test the response status is correctly traced. Also guard against nil
response/status, which might happen if the middleware is inserted into
Excon before the Excon::Middleware::ResponseParser.