Skip to content

Conversation

@keithmgould
Copy link
Contributor

@keithmgould keithmgould commented Nov 18, 2016

Currently the http verb is not passed to the recognize_path method. This means that all paths are interpreted as GET (see here).

We are currently getting false negatives due to this problem.

This PR fixes by passing in the http verb.

Due to the method (recognize_path) being part of Rails (not this gem) we had to continue to only stub the method, so I could not make a true "failing test."

@keithmgould
Copy link
Contributor Author

Adresses: #84

@jcarres-mdsol
Copy link
Collaborator

Cool, good changes.
The CI failed on JRuby but seems a transient error to me, try pushing again.
Also, you'll need to update the version and the Changelog so we can release a new version

@codefromthecrypt
Copy link
Member

ps opened #86 in case it helps w/jruby flake

@keithmgould
Copy link
Contributor Author

thanks @jcarres-mdsol.

bumped version and edited change log.

@jcarres-mdsol
Copy link
Collaborator

Merging, thanks!

@jcarres-mdsol jcarres-mdsol merged commit 6dac69a into openzipkin:master Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants