passes the http verb to the recognize_path method #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the http verb is not passed to the recognize_path method. This means that all paths are interpreted as GET (see here).
We are currently getting false negatives due to this problem.
This PR fixes by passing in the http verb.
Due to the method (recognize_path) being part of Rails (not this gem) we had to continue to only stub the method, so I could not make a true "failing test."