fixes faraday middleware and add new convenient classes #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if @sampled_as_boolean | ||
| @logger && @logger.warn("Using a boolean in the Sampled header is deprecated. Consider setting sampled_as_boolean to false") | ||
| end | ||
| Trace.sample_rate = @sample_rate |
spec/lib/config_spec.rb
Outdated
| :zookeeper, :log_tracing, | ||
| :annotate_plugin, :filter_plugin, :whitelist_plugin].each do |method| | ||
| it "can set and read configuration values for #{method}" do | ||
| it 'can set and read configuration values for #{method}' do |
JordiPolo
force-pushed
the
fix_faraday_setting_ids
branch
from
af9e7be to
52b1a2d
Compare
JordiPolo
force-pushed
the
fix_faraday_setting_ids
branch
from
52b1a2d to
06f1ecd
Compare
Member
codefromthecrypt
left a comment
codefromthecrypt
left a comment
There was a problem hiding this comment.
easier to see what's going on. Do you consider TraceContainer and TraceGenerator internal details or a part of the api? do they invalidate or warrant anything in the README?
Collaborator
Author
|
Still internal details, give it a new couple of versions to mature, just in case. |
codefromthecrypt
approved these changes
Dec 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The faraday middleware created ids and cleaned up after him which is good, except when there were no ids to begin with.
This fixes the issue and allows to always clean up after him.
Also added more classes because I like classes
@ykitamura-mdsol @adriancole @jfeltesse-mdsol @ssteeg-mdsol