chore: Improve proportions and colors of buttons, add to design system#1049
Merged
shiroyasha merged 1 commit intomainfrom Sep 4, 2024
Merged
chore: Improve proportions and colors of buttons, add to design system#1049shiroyasha merged 1 commit intomainfrom
shiroyasha merged 1 commit intomainfrom
Conversation
Signed-off-by: Marko Anastasov <marko@operately.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a previous PR #956 I added buttons to the design system that were actually not properly componentized nor used anywhere apart from my mockup #882.
While designing further I decided to adapt the existing
FilledButtonandGhostButtoncomponents.The video shows before and after. In both cases these are the Filled and Ghostbuttons. The switch to new happens at ~00:23:
buttons.mp4