fix: Comments on Project Discussions now appear in the feed#3842
Merged
Conversation
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- In fetch_comment_thread_context, add a fallback clause for unexpected parent_type values to avoid runtime crashes when a new thread type is introduced.
- In the TS handler, replace the
anytype on activityLink with a more precise ReactNode or JSX.Element to maintain type safety and avoid suppressing errors. - Since you made project non‐nullable and added space_id to the API, double-check that existing clients won’t break and consider a deprecation strategy if you’re removing previously optional fields.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In fetch_comment_thread_context, add a fallback clause for unexpected parent_type values to avoid runtime crashes when a new thread type is introduced.
- In the TS handler, replace the `any` type on activityLink with a more precise ReactNode or JSX.Element to maintain type safety and avoid suppressing errors.
- Since you made project non‐nullable and added space_id to the API, double-check that existing clients won’t break and consider a deprecation strategy if you’re removing previously optional fields.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although events were being correctly created when comments were added to a Project Discussion, the permissions for the event were not being set correctly. So, the events were not shown in the feed. This problem is now fixed.