Skip to content

fix: Comments on Project Discussions now appear in the feed#3842

Merged
Rockyy174 merged 2 commits into
operately:mainfrom
Rockyy174:project-discussion-comment
Nov 18, 2025
Merged

fix: Comments on Project Discussions now appear in the feed#3842
Rockyy174 merged 2 commits into
operately:mainfrom
Rockyy174:project-discussion-comment

Conversation

@Rockyy174
Copy link
Copy Markdown
Collaborator

@Rockyy174 Rockyy174 commented Nov 18, 2025

Although events were being correctly created when comments were added to a Project Discussion, the permissions for the event were not being set correctly. So, the events were not shown in the feed. This problem is now fixed.

Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • In fetch_comment_thread_context, add a fallback clause for unexpected parent_type values to avoid runtime crashes when a new thread type is introduced.
  • In the TS handler, replace the any type on activityLink with a more precise ReactNode or JSX.Element to maintain type safety and avoid suppressing errors.
  • Since you made project non‐nullable and added space_id to the API, double-check that existing clients won’t break and consider a deprecation strategy if you’re removing previously optional fields.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In fetch_comment_thread_context, add a fallback clause for unexpected parent_type values to avoid runtime crashes when a new thread type is introduced.
- In the TS handler, replace the `any` type on activityLink with a more precise ReactNode or JSX.Element to maintain type safety and avoid suppressing errors.
- Since you made project non‐nullable and added space_id to the API, double-check that existing clients won’t break and consider a deprecation strategy if you’re removing previously optional fields.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
@Rockyy174 Rockyy174 merged commit c78a2cf into operately:main Nov 18, 2025
3 checks passed
@Rockyy174 Rockyy174 deleted the project-discussion-comment branch November 18, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant