Skip to content

fix: Add zero state to closed Goal discussions#4026

Merged
Rockyy174 merged 1 commit into
operately:mainfrom
Rockyy174:discussions-zero-state
Jan 9, 2026
Merged

fix: Add zero state to closed Goal discussions#4026
Rockyy174 merged 1 commit into
operately:mainfrom
Rockyy174:discussions-zero-state

Conversation

@Rockyy174
Copy link
Copy Markdown
Collaborator

Fixes #3515.

Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The zero-state rendering logic now duplicates the props.state === "closed" and props.state !== "closed" checks in multiple places; consider centralizing this into a small helper or a single conditional block to make the behavior easier to reason about and maintain.
  • The new DiscussionsZeroStateClosed component is very similar to DiscussionsZeroState; you might consider a single configurable zero-state component that takes the message/description as props to avoid duplication.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The zero-state rendering logic now duplicates the `props.state === "closed"` and `props.state !== "closed"` checks in multiple places; consider centralizing this into a small helper or a single conditional block to make the behavior easier to reason about and maintain.
- The new `DiscussionsZeroStateClosed` component is very similar to `DiscussionsZeroState`; you might consider a single configurable zero-state component that takes the message/description as props to avoid duplication.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Rockyy174 Rockyy174 merged commit c0e9bb6 into operately:main Jan 9, 2026
3 checks passed
@Rockyy174 Rockyy174 deleted the discussions-zero-state branch January 9, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zero state missing in Discussions tab on Goal page when Goal is closed

1 participant