fix: Add zero state to closed Goal discussions#4026
Merged
Conversation
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The zero-state rendering logic now duplicates the
props.state === "closed"andprops.state !== "closed"checks in multiple places; consider centralizing this into a small helper or a single conditional block to make the behavior easier to reason about and maintain. - The new
DiscussionsZeroStateClosedcomponent is very similar toDiscussionsZeroState; you might consider a single configurable zero-state component that takes the message/description as props to avoid duplication.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The zero-state rendering logic now duplicates the `props.state === "closed"` and `props.state !== "closed"` checks in multiple places; consider centralizing this into a small helper or a single conditional block to make the behavior easier to reason about and maintain.
- The new `DiscussionsZeroStateClosed` component is very similar to `DiscussionsZeroState`; you might consider a single configurable zero-state component that takes the message/description as props to avoid duplication.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3515.