Skip to content

chore: Preload only Goal's related work the user can view#4070

Merged
Rockyy174 merged 1 commit into
operately:mainfrom
Rockyy174:goal-related-work
Jan 22, 2026
Merged

chore: Preload only Goal's related work the user can view#4070
Rockyy174 merged 1 commit into
operately:mainfrom
Rockyy174:goal-related-work

Conversation

@Rockyy174
Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The new step names like refute_nested_related_work_items_hidden are a bit hard to parse due to the double negative; consider renaming to something more direct (e.g. refute_nested_hidden_related_work_items or assert_nested_hidden_related_work_items_not_visible) to make the intent clearer.
  • The new factory steps repeat the Binding.no_access() / Binding.view_access() configuration in multiple places; consider extracting small helper functions or factory traits for these common access setups to make the tests easier to read and maintain.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The new step names like `refute_nested_related_work_items_hidden` are a bit hard to parse due to the double negative; consider renaming to something more direct (e.g. `refute_nested_hidden_related_work_items` or `assert_nested_hidden_related_work_items_not_visible`) to make the intent clearer.
- The new factory steps repeat the `Binding.no_access()` / `Binding.view_access()` configuration in multiple places; consider extracting small helper functions or factory traits for these common access setups to make the tests easier to read and maintain.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Rockyy174 Rockyy174 merged commit 065ae31 into operately:main Jan 22, 2026
3 checks passed
@Rockyy174 Rockyy174 deleted the goal-related-work branch January 22, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant