chore: Preload only Goal's related work the user can view#4070
Merged
Conversation
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new step names like
refute_nested_related_work_items_hiddenare a bit hard to parse due to the double negative; consider renaming to something more direct (e.g.refute_nested_hidden_related_work_itemsorassert_nested_hidden_related_work_items_not_visible) to make the intent clearer. - The new factory steps repeat the
Binding.no_access()/Binding.view_access()configuration in multiple places; consider extracting small helper functions or factory traits for these common access setups to make the tests easier to read and maintain.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new step names like `refute_nested_related_work_items_hidden` are a bit hard to parse due to the double negative; consider renaming to something more direct (e.g. `refute_nested_hidden_related_work_items` or `assert_nested_hidden_related_work_items_not_visible`) to make the intent clearer.
- The new factory steps repeat the `Binding.no_access()` / `Binding.view_access()` configuration in multiple places; consider extracting small helper functions or factory traits for these common access setups to make the tests easier to read and maintain.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.