chore: System settings key can be rotated

[Rockyy174]

No description provided.

[sourcery-ai]

Hey - I've left some high level feedback:

• In encryption_base_secrets/0, only the first element is checked for nil, so a list like ["k1", nil] will pass and later blow up in KeyGenerator.generate/4; consider validating that all keys are non-nil (e.g., Enum.any?(keys, &is_nil/1) and raising early).
• The decrypt/1 implementation using Enum.reduce_while/3 ignores the accumulator and always starts with {:error, :invalid}; using Enum.find_value/2 or a small recursive helper would make the intent clearer and avoid the dummy accumulator value.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `encryption_base_secrets/0`, only the first element is checked for `nil`, so a list like `["k1", nil]` will pass and later blow up in `KeyGenerator.generate/4`; consider validating that *all* keys are non-nil (e.g., `Enum.any?(keys, &is_nil/1)` and raising early).
- The `decrypt/1` implementation using `Enum.reduce_while/3` ignores the accumulator and always starts with `{:error, :invalid}`; using `Enum.find_value/2` or a small recursive helper would make the intent clearer and avoid the dummy accumulator value.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}