chore: Adjust edit and full-access permissions#4100
Merged
Conversation
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- There are many scattered permission thresholds (e.g. edit vs full) encoded directly in different permission modules and large test tables; consider centralizing this into a shared permission matrix or helper so that future policy changes don’t require touching so many call sites.
- Since
contribute_accessis being removed fromBinding, it’s worth scanning for any remaining type specs, pattern matches, or atoms that still reference:contribute_accessoutside this diff (e.g. filters or loaders) to avoid dead or misleading branches.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There are many scattered permission thresholds (e.g. edit vs full) encoded directly in different permission modules and large test tables; consider centralizing this into a shared permission matrix or helper so that future policy changes don’t require touching so many call sites.
- Since `contribute_access` is being removed from `Binding`, it’s worth scanning for any remaining type specs, pattern matches, or atoms that still reference `:contribute_access` outside this diff (e.g. filters or loaders) to avoid dead or misleading branches.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
4237a78 to
7a4f87f
Compare
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
7a4f87f to
15a284d
Compare
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.