Skip to content

chore: Adjust edit and full-access permissions#4100

Merged
Rockyy174 merged 9 commits into
operately:mainfrom
Rockyy174:adjust-permissions
Jan 30, 2026
Merged

chore: Adjust edit and full-access permissions#4100
Rockyy174 merged 9 commits into
operately:mainfrom
Rockyy174:adjust-permissions

Conversation

@Rockyy174
Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • There are many scattered permission thresholds (e.g. edit vs full) encoded directly in different permission modules and large test tables; consider centralizing this into a shared permission matrix or helper so that future policy changes don’t require touching so many call sites.
  • Since contribute_access is being removed from Binding, it’s worth scanning for any remaining type specs, pattern matches, or atoms that still reference :contribute_access outside this diff (e.g. filters or loaders) to avoid dead or misleading branches.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- There are many scattered permission thresholds (e.g. edit vs full) encoded directly in different permission modules and large test tables; consider centralizing this into a shared permission matrix or helper so that future policy changes don’t require touching so many call sites.
- Since `contribute_access` is being removed from `Binding`, it’s worth scanning for any remaining type specs, pattern matches, or atoms that still reference `:contribute_access` outside this diff (e.g. filters or loaders) to avoid dead or misleading branches.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
@Rockyy174 Rockyy174 merged commit 720298f into operately:main Jan 30, 2026
3 checks passed
@Rockyy174 Rockyy174 deleted the adjust-permissions branch January 30, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant