Skip to content

fix: Fix task-description-update feed item link#4148

Merged
Rockyy174 merged 2 commits into
operately:mainfrom
Rockyy174:fix-task-description-feed
Feb 10, 2026
Merged

fix: Fix task-description-update feed item link#4148
Rockyy174 merged 2 commits into
operately:mainfrom
Rockyy174:fix-task-description-feed

Conversation

@Rockyy174
Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • In TaskDescriptionChange.NotificationTitle, using task?.name can result in user-facing strings like Updated the description of: undefined when task is null; consider falling back to a generic label (e.g. "a task") in that case to keep the notification text clean.
  • In TaskDescriptionChange.FeedItemTitle, the space-task branch falls back to task.name when space is missing, but task itself can be null; it would be safer to mirror the non-space branch and fall back to a plain string like "a task" when either task or task.name is unavailable.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In `TaskDescriptionChange.NotificationTitle`, using `task?.name` can result in user-facing strings like `Updated the description of: undefined` when `task` is null; consider falling back to a generic label (e.g. `"a task"`) in that case to keep the notification text clean.
- In `TaskDescriptionChange.FeedItemTitle`, the space-task branch falls back to `task.name` when `space` is missing, but `task` itself can be null; it would be safer to mirror the non-space branch and fall back to a plain string like `"a task"` when either `task` or `task.name` is unavailable.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Rockyy174 Rockyy174 merged commit 5147075 into operately:main Feb 10, 2026
3 checks passed
@Rockyy174 Rockyy174 deleted the fix-task-description-feed branch February 10, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant