chore: Adjust all required and optional fields in API#4261
Merged
Rockyy174 merged 2 commits intooperately:mainfrom Mar 20, 2026
Merged
chore: Adjust all required and optional fields in API#4261Rockyy174 merged 2 commits intooperately:mainfrom
Rockyy174 merged 2 commits intooperately:mainfrom
Conversation
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
OperatelyWeb.Api.Goals.update_target/2, the repeatedupdate_attrs = if attrs[:...], do: ...blocks could be simplified using something likeattrs |> Map.take([:name, :start_value, :target_value, :unit]) |> Enum.reduce(%{}, ...)or by composing a mapping function, which would be easier to extend and less error-prone. - Now that the goal and project
*_access_levelinputs are required integers in both the API schema and TS types, consider introducing a shared enum or dedicated type for access levels instead of plainnumber/:integerto avoid magic values and make incorrect usage harder at compile time.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `OperatelyWeb.Api.Goals.update_target/2`, the repeated `update_attrs = if attrs[:...], do: ...` blocks could be simplified using something like `attrs |> Map.take([:name, :start_value, :target_value, :unit]) |> Enum.reduce(%{}, ...)` or by composing a mapping function, which would be easier to extend and less error-prone.
- Now that the goal and project `*_access_level` inputs are required integers in both the API schema and TS types, consider introducing a shared enum or dedicated type for access levels instead of plain `number`/`:integer` to avoid magic values and make incorrect usage harder at compile time.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.