fix: Notification email delivery state is now updated#4317
Merged
Conversation
Signed-off-by: Adriano Lazzaretti <lazzaretti136@gmail.com>
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
EmailWorker,deliver_email/3is just wrappingapply/3to normalize the return; you could simplify by pattern-matching directly on theapply/3result inperform/1and avoid an extra private function. - In
EmailDelivery.mark_sent/2for lists,Repo.update_all/3’s return value is ignored and a static{:ok, true}is returned; consider returning or at least checking the affected row count to avoid silently succeeding when nothing was updated (e.g. due to stale IDs).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `EmailWorker`, `deliver_email/3` is just wrapping `apply/3` to normalize the return; you could simplify by pattern-matching directly on the `apply/3` result in `perform/1` and avoid an extra private function.
- In `EmailDelivery.mark_sent/2` for lists, `Repo.update_all/3`’s return value is ignored and a static `{:ok, true}` is returned; consider returning or at least checking the affected row count to avoid silently succeeding when nothing was updated (e.g. due to stale IDs).Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.